Re: [PATCH v2 2/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces

Christoph Hellwig
2016-08-03T09:03:12Z

On Tue, Aug 02, 2016 at 10:53:36AM +0300, Sagi Grimberg wrote:
> nvme_uninit_ctrl already does that for us. Note that we reordered
> nvme_rdma_shutdown_ctrl and nvme_uninit_ctrl, this is perfectly
> fine because we actually want ctrl uninit (aen, scan cancellation
> and namespaces removal) to happen before we shutdown the rdma
> resources.
>
> Also, centralize the deletion work and the dead controller removal
> work code duplication into __nvme_rdma_shutdown_ctrl that accepts
> a shutdown boolean.