From: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Cc: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Subject: [PATCH v3 07/15] IB/pvrdma: Add device command support
Date: Wed, 3 Aug 2016 16:27:36 -0700 [thread overview]
Message-ID: <1470266864-16888-8-git-send-email-aditr@vmware.com> (raw)
In-Reply-To: <1470266864-16888-1-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
This patch enables posting Verb requests and receiving responses to/from
the backend PVRDMA emulation layer.
Changes v2->v3:
- Converted pvrdma_cmd_recv to inline.
- Added a min check in the memcpy to cmd_slot.
- Removed the boolean from pvrdma_cmd_post.
Reviewed-by: Jorgen Hansen <jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Reviewed-by: George Zhang <georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Reviewed-by: Aditya Sarwade <asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Reviewed-by: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Signed-off-by: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
---
drivers/infiniband/hw/pvrdma/pvrdma_cmd.c | 105 ++++++++++++++++++++++++++++++
1 file changed, 105 insertions(+)
create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma_cmd.c
diff --git a/drivers/infiniband/hw/pvrdma/pvrdma_cmd.c b/drivers/infiniband/hw/pvrdma/pvrdma_cmd.c
new file mode 100644
index 0000000..45aa31f
--- /dev/null
+++ b/drivers/infiniband/hw/pvrdma/pvrdma_cmd.c
@@ -0,0 +1,105 @@
+/*
+ * Copyright (c) 2012-2016 VMware, Inc. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of EITHER the GNU General Public License
+ * version 2 as published by the Free Software Foundation or the BSD
+ * 2-Clause License. This program is distributed in the hope that it
+ * will be useful, but WITHOUT ANY WARRANTY; WITHOUT EVEN THE IMPLIED
+ * WARRANTY OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE.
+ * See the GNU General Public License version 2 for more details at
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program available in the file COPYING in the main
+ * directory of this source tree.
+ *
+ * The BSD 2-Clause License
+ *
+ * Redistribution and use in source and binary forms, with or
+ * without modification, are permitted provided that the following
+ * conditions are met:
+ *
+ * - Redistributions of source code must retain the above
+ * copyright notice, this list of conditions and the following
+ * disclaimer.
+ *
+ * - Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following
+ * disclaimer in the documentation and/or other materials
+ * provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
+ * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <linux/list.h>
+
+#include "pvrdma.h"
+
+#define PVRDMA_CMD_TIMEOUT 10000 /* ms */
+
+static inline int pvrdma_cmd_recv(struct pvrdma_dev *dev,
+ union pvrdma_cmd_resp *resp)
+{
+ dev_dbg(&dev->pdev->dev, "receive response from device\n");
+
+ spin_lock(&dev->cmd_lock);
+ memcpy(resp, dev->resp_slot, sizeof(*resp));
+ spin_unlock(&dev->cmd_lock);
+
+ return 0;
+}
+
+int
+pvrdma_cmd_post(struct pvrdma_dev *dev, union pvrdma_cmd_req *req,
+ union pvrdma_cmd_resp *resp)
+{
+ int err;
+
+ dev_dbg(&dev->pdev->dev, "post request to device\n");
+
+ /* Serializiation */
+ down(&dev->cmd_sema);
+
+ spin_lock(&dev->cmd_lock);
+ memcpy(dev->cmd_slot, req, min(PAGE_SIZE, sizeof(*req)));
+ spin_unlock(&dev->cmd_lock);
+
+ init_completion(&dev->cmd_done);
+ pvrdma_write_reg(dev, PVRDMA_REG_REQUEST, 0);
+
+ /* Make sure the request is written before reading status. */
+ mb();
+ err = pvrdma_read_reg(dev, PVRDMA_REG_ERR);
+ if (err == 0) {
+ if (resp != NULL) {
+ err = wait_for_completion_interruptible_timeout(
+ &dev->cmd_done,
+ msecs_to_jiffies(PVRDMA_CMD_TIMEOUT));
+ if (err == 0 || err == -ERESTARTSYS) {
+ dev_err(&dev->pdev->dev,
+ "completion timeout or interrupted\n");
+ err = -ETIMEDOUT;
+ } else {
+ err = pvrdma_cmd_recv(dev, resp);
+ }
+ }
+ } else {
+ dev_warn(&dev->pdev->dev, "failed to write request %d\n", err);
+ }
+
+ up(&dev->cmd_sema);
+
+ return err;
+}
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-03 23:27 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 23:27 [PATCH v3 00/15] Add Paravirtual RDMA Driver Adit Ranadive
[not found] ` <1470266864-16888-1-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-03 23:27 ` [PATCH v3 01/15] IB/pvrdma: Add user-level shared functions Adit Ranadive
[not found] ` <1470266864-16888-2-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-21 11:24 ` Yuval Shaia
[not found] ` <20160821112436.GA22012-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-09-06 18:58 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 02/15] IB/pvrdma: Add virtual device RDMA structures Adit Ranadive
[not found] ` <1470266864-16888-3-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-21 11:54 ` Yuval Shaia
[not found] ` <20160821115441.GB22012-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-08-23 17:46 ` Adit Ranadive
[not found] ` <BLUPR0501MB836ACEAF51DF69E5623EBF5C5EB0-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-08-25 6:03 ` Yuval Shaia
2016-09-06 19:03 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 03/15] IB/pvrdma: Add the paravirtual RDMA device specification Adit Ranadive
[not found] ` <1470266864-16888-4-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-10 16:51 ` Leon Romanovsky
2016-08-03 23:27 ` [PATCH v3 04/15] IB/pvrdma: Add functions for Verbs support Adit Ranadive
[not found] ` <1470266864-16888-5-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-23 15:13 ` Yuval Shaia
2016-08-23 18:43 ` Leon Romanovsky
[not found] ` <20160823184322.GM15065-2ukJVAZIZ/Y@public.gmane.org>
2016-08-23 18:52 ` Adit Ranadive
[not found] ` <BLUPR0501MB836B1C542C1296616A05080C5EB0-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-08-23 20:56 ` Leon Romanovsky
2016-08-23 19:07 ` Doug Ledford
2016-08-25 7:30 ` Yuval Shaia
2016-09-07 17:00 ` Adit Ranadive
[not found] ` <BLUPR0501MB836F2A8282244C2821DC346C5F80-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08 8:38 ` Yuval Shaia
[not found] ` <20160908083800.GA7760-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-08 18:34 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 05/15] IB/pvrdma: Add paravirtual rdma device Adit Ranadive
[not found] ` <1470266864-16888-6-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25 9:59 ` Yuval Shaia
[not found] ` <20160825095920.GB14419-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-08-28 13:06 ` Leon Romanovsky
[not found] ` <20160828130657.GM594-2ukJVAZIZ/Y@public.gmane.org>
2016-08-28 13:41 ` Yuval Shaia
2016-08-28 13:50 ` Leon Romanovsky
[not found] ` <20160828135048.GO594-2ukJVAZIZ/Y@public.gmane.org>
2016-08-28 15:50 ` Adit Ranadive
2016-08-29 13:59 ` Yuval Shaia
2016-08-03 23:27 ` [PATCH v3 06/15] IB/pvrdma: Add helper functions Adit Ranadive
[not found] ` <1470266864-16888-7-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25 6:16 ` Yuval Shaia
2016-08-25 6:29 ` Yuval Shaia
2016-08-29 12:08 ` Yuval Shaia
2016-09-07 19:26 ` Adit Ranadive
2016-08-03 23:27 ` Adit Ranadive [this message]
[not found] ` <1470266864-16888-8-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-04 4:30 ` [PATCH v3 07/15] IB/pvrdma: Add device command support Leon Romanovsky
2016-08-25 10:08 ` Yuval Shaia
2016-08-03 23:27 ` [PATCH v3 08/15] IB/pvrdma: Add support for Completion Queues Adit Ranadive
[not found] ` <1470266864-16888-9-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25 12:41 ` Yuval Shaia
[not found] ` <20160825124120.GB27446-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-09-07 17:25 ` Adit Ranadive
[not found] ` <BLUPR0501MB83629470B22B65E27B4332AC5F80-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08 8:18 ` Yuval Shaia
[not found] ` <20160908081802.GA3300-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-08 18:26 ` Adit Ranadive
[not found] ` <BLUPR0501MB836A35B3F4B839B1E2055A8C5FB0-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08 18:46 ` Jason Gunthorpe
[not found] ` <20160908184608.GG21614-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-08 18:56 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 09/15] IB/pvrdma: Add UAR support Adit Ranadive
[not found] ` <1470266864-16888-10-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-10 3:54 ` Leon Romanovsky
2016-08-25 13:13 ` Yuval Shaia
2016-08-03 23:27 ` [PATCH v3 10/15] IB/pvrdma: Add support for memory regions Adit Ranadive
[not found] ` <1470266864-16888-11-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25 14:15 ` Yuval Shaia
[not found] ` <20160825141505.GD27446-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-09-07 19:06 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 11/15] IB/pvrdma: Add Queue Pair support Adit Ranadive
[not found] ` <1470266864-16888-12-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-10 4:16 ` Leon Romanovsky
2016-08-29 14:44 ` Yuval Shaia
2016-09-07 19:33 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 12/15] IB/pvrdma: Add the main driver module for PVRDMA Adit Ranadive
[not found] ` <1470266864-16888-13-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-04 6:53 ` Leon Romanovsky
[not found] ` <20160804065352.GJ27667-2ukJVAZIZ/Y@public.gmane.org>
2016-08-04 19:18 ` Adit Ranadive
2016-09-01 13:20 ` Yuval Shaia
[not found] ` <20160901132024.GA26356-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-07 19:41 ` Adit Ranadive
[not found] ` <BLUPR0501MB836EF38D944CD38F8897C07C5F80-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08 15:25 ` Yuval Shaia
[not found] ` <20160908152541.GA3352-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-08 18:40 ` Adit Ranadive
2016-09-01 16:54 ` Yuval Shaia
[not found] ` <20160901165404.GA3429-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-07 20:19 ` Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 13/15] IB/pvrdma: Add Kconfig and Makefile Adit Ranadive
2016-08-03 23:27 ` [PATCH v3 14/15] IB: Add PVRDMA driver Adit Ranadive
[not found] ` <1470266864-16888-15-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-04 2:30 ` kbuild test robot
2016-08-06 5:34 ` kbuild test robot
2016-08-03 23:27 ` [PATCH v3 15/15] MAINTAINERS: Update for " Adit Ranadive
[not found] ` <1470266864-16888-16-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-30 13:17 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470266864-16888-8-git-send-email-aditr@vmware.com \
--to=aditr-pghwnbhtmq7qt0dzr+alfa@public.gmane.org \
--cc=asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).