From: "Dalessandro, Dennis" <dennis.dalessandro@intel.com>
To: "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"Hefty, Sean" <sean.hefty@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] IB/hfi1: Add missing error code assignment before test
Date: Wed, 10 Aug 2016 16:10:58 +0000 [thread overview]
Message-ID: <1470845455.2576.6.camel@intel.com> (raw)
In-Reply-To: <1470807267-12714-1-git-send-email-christophe.jaillet@wanadoo.fr>
On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
> It is likely that checking the result of 'setup_ctxt' is expected
> here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index 1ecbec192358..ed76be39b20b 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
> ret = assign_ctxt(fp, &uinfo);
> if (ret < 0)
> return ret;
> - setup_ctxt(fp);
> + ret = setup_ctxt(fp);
> if (ret)
> return ret;
> ret = user_init(fp);
Thanks for the patch.
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2016-08-10 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 5:34 [PATCH] IB/hfi1: Add missing error code assignment before test Christophe JAILLET
2016-08-10 16:10 ` Dalessandro, Dennis [this message]
2016-08-22 18:23 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470845455.2576.6.camel@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox