* [PATCH] IB/hfi1: Add missing error code assignment before test
@ 2016-08-10 5:34 Christophe JAILLET
2016-08-10 16:10 ` Dalessandro, Dennis
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2016-08-10 5:34 UTC (permalink / raw)
To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w,
dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Christophe JAILLET
It is likely that checking the result of 'setup_ctxt' is expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@public.gmane.org>
---
drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c
index 1ecbec192358..ed76be39b20b 100644
--- a/drivers/infiniband/hw/hfi1/file_ops.c
+++ b/drivers/infiniband/hw/hfi1/file_ops.c
@@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp, unsigned int cmd,
ret = assign_ctxt(fp, &uinfo);
if (ret < 0)
return ret;
- setup_ctxt(fp);
+ ret = setup_ctxt(fp);
if (ret)
return ret;
ret = user_init(fp);
--
2.7.4
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/hfi1: Add missing error code assignment before test
2016-08-10 5:34 [PATCH] IB/hfi1: Add missing error code assignment before test Christophe JAILLET
@ 2016-08-10 16:10 ` Dalessandro, Dennis
2016-08-22 18:23 ` Doug Ledford
0 siblings, 1 reply; 3+ messages in thread
From: Dalessandro, Dennis @ 2016-08-10 16:10 UTC (permalink / raw)
To: christophe.jaillet@wanadoo.fr, hal.rosenstock@gmail.com,
Marciniszyn, Mike, dledford@redhat.com, Hefty, Sean
Cc: linux-kernel@vger.kernel.org, Dalessandro, Dennis,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
> It is likely that checking the result of 'setup_ctxt' is expected
> here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/hw/hfi1/file_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/file_ops.c
> b/drivers/infiniband/hw/hfi1/file_ops.c
> index 1ecbec192358..ed76be39b20b 100644
> --- a/drivers/infiniband/hw/hfi1/file_ops.c
> +++ b/drivers/infiniband/hw/hfi1/file_ops.c
> @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp,
> unsigned int cmd,
> ret = assign_ctxt(fp, &uinfo);
> if (ret < 0)
> return ret;
> - setup_ctxt(fp);
> + ret = setup_ctxt(fp);
> if (ret)
> return ret;
> ret = user_init(fp);
Thanks for the patch.
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/hfi1: Add missing error code assignment before test
2016-08-10 16:10 ` Dalessandro, Dennis
@ 2016-08-22 18:23 ` Doug Ledford
0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2016-08-22 18:23 UTC (permalink / raw)
To: Dalessandro, Dennis, christophe.jaillet@wanadoo.fr,
hal.rosenstock@gmail.com, Marciniszyn, Mike, Hefty, Sean
Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]
On 8/10/2016 12:10 PM, Dalessandro, Dennis wrote:
> On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote:
>> It is likely that checking the result of 'setup_ctxt' is expected
>> here.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>
> Thanks for the patch.
>
> Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-22 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10 5:34 [PATCH] IB/hfi1: Add missing error code assignment before test Christophe JAILLET
2016-08-10 16:10 ` Dalessandro, Dennis
2016-08-22 18:23 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox