Re: [PATCH rdma-next 6/6] RDMA/core: Unify style of IOCTL commands

Dalessandro, Dennis
2016-08-16T14:31:32Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 841 bytes --]

On Tue, 2016-08-16 at 16:45 +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> MAD and HFI1 have different naming convention, this patch
> simplifies and unifies their defines and names.

I don't know that I agree that it simplifies things. It changes a lot
of code for not much real value in my opinion.Â

Was this something that was discussed in the verbs call? I have not
been able to attend that the last few weeks.

> As part of cleanup, the HFI1 _NUM() macro was removed and MAD
> indexes were renamed. It has a potential to break application
> which use these defines directly.

Why do you want to remove the _NUM() macro that Doug just put in?

-DennyN‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš