From: "Dalessandro, Dennis" <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"Dalessandro,
Dennis"
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-next 6/6] RDMA/core: Unify style of IOCTL commands
Date: Wed, 17 Aug 2016 13:45:21 +0000 [thread overview]
Message-ID: <1471441516.19634.15.camel@intel.com> (raw)
In-Reply-To: <20160817051952.GC5489-2ukJVAZIZ/Y@public.gmane.org>
On Wed, 2016-08-17 at 08:19 +0300, Leon Romanovsky wrote:
> > I'm not opposed to trying to unify things, however this seems to be
> > more than plop down the hfi1 stuff from here and put it over there.
> > It
> > is certainly not simplifying anything.
>
> It is "dark side" of UAPI - inability to change legacy declarations.
> This is why I didn't remove anything except _NUM() macro.
>
> The simplification comes from definition of one place for
> declaration of IOCTLs numbers and exporting it to users. It gives
> visibility for user space authors too.
How often does a user need the IOCTL numbers for MAD and PSM and
whatever else we come up with at the same time? Why would they care
about the other IOCTL numbers?
I don't really see a problem with keeping them separate, but I'm not
really opposed to collapsing into one place either.
-Denny
next prev parent reply other threads:[~2016-08-17 13:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 13:45 [PATCH rdma-next 0/6] Refactor RDMA IOCTL declarations Leon Romanovsky
[not found] ` <1471355123-6227-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-16 13:45 ` [PATCH rdma-next 1/6] RDMA/core: Commonize RDMA IOCTL declarations location Leon Romanovsky
2016-08-16 13:45 ` [PATCH rdma-next 2/6] RDMA/core: Move legacy MAD IOCTL declarations to common file Leon Romanovsky
2016-08-16 13:45 ` [PATCH rdma-next 3/6] RDMA/hfi1: Avoid redeclaration error Leon Romanovsky
[not found] ` <1471355123-6227-4-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-16 17:15 ` Dalessandro, Dennis
[not found] ` <1471367729.2661.50.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-17 5:09 ` Leon Romanovsky
2016-08-17 6:01 ` ira.weiny
[not found] ` <20160817060139.GA27477-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-08-17 6:45 ` Leon Romanovsky
2016-08-16 13:45 ` [PATCH rdma-next 4/6] RDMA/core: Move HFI1 IOCTL declarations to common file Leon Romanovsky
[not found] ` <1471355123-6227-5-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-17 6:16 ` ira.weiny
[not found] ` <20160817061630.GB27477-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-08-17 6:55 ` Leon Romanovsky
[not found] ` <20160817065529.GG5489-2ukJVAZIZ/Y@public.gmane.org>
2016-08-17 13:35 ` Dalessandro, Dennis
[not found] ` <1471440949.19634.7.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-17 14:16 ` Leon Romanovsky
2016-08-17 18:10 ` ira.weiny
[not found] ` <20160817181050.GC27477-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-08-18 6:23 ` Leon Romanovsky
2016-08-19 18:32 ` Jason Gunthorpe
2016-08-16 13:45 ` [PATCH rdma-next 5/6] RDMA/core: Rename RDMA magic number Leon Romanovsky
2016-08-16 13:45 ` [PATCH rdma-next 6/6] RDMA/core: Unify style of IOCTL commands Leon Romanovsky
[not found] ` <1471355123-6227-7-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-16 14:31 ` Dalessandro, Dennis
[not found] ` <1471357887.2661.28.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-16 16:50 ` Leon Romanovsky
[not found] ` <20160816165041.GA5489-2ukJVAZIZ/Y@public.gmane.org>
2016-08-16 17:09 ` Dalessandro, Dennis
[not found] ` <1471367364.2661.45.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-17 5:19 ` Leon Romanovsky
[not found] ` <20160817051952.GC5489-2ukJVAZIZ/Y@public.gmane.org>
2016-08-17 13:45 ` Dalessandro, Dennis [this message]
[not found] ` <1471441516.19634.15.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-17 14:20 ` Leon Romanovsky
2016-08-18 11:08 ` [PATCH rdma-next 0/6] Refactor RDMA IOCTL declarations Yuval Shaia
[not found] ` <20160818110819.GB8590-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-08-18 11:28 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471441516.19634.15.camel@intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox