From: "Dalessandro, Dennis" <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org"
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: "matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH rdma-next V2 6/6] RDMA/core: Unify style of IOCTL commands
Date: Thu, 1 Sep 2016 17:17:26 +0000 [thread overview]
Message-ID: <1472750241.16467.29.camel@intel.com> (raw)
In-Reply-To: <20160901171129.GB19982-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Thu, 2016-09-01 at 11:11 -0600, Jason Gunthorpe wrote:
> On Thu, Sep 01, 2016 at 05:09:31PM +0000, Dalessandro, Dennis wrote:
>
> > > Dennis should use an internal definition in PSM if he wishes to
> > > continue to support the staging kernel ABI.
> >
> > It's not just the backward compatibility. PSM uses these command
> > definitions.So this breaks current support with current driver.
>
> How exactly? The HFI1_CMD_ASSIGN_CTXT constant is never used in the
> kernel?
This is used in PSM library. Agree it's not used in the kernel, so I
can see the argument to get rid of it, or not care. However
removing/changing it breaks PSM and requires changes. They are not hard
changes to make, but as it stands now PSM will work with 4.7 but not
with 4.8.
Reverting this part of the patch doesn't change or detract from what
the series does in the first place. Patch still accomplishes its job.
-Denny
next prev parent reply other threads:[~2016-09-01 17:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 21:31 [PATCH rdma-next V2 0/6] Refactor RDMA IOCTL declarations Leon Romanovsky
[not found] ` <1471987907-6336-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-23 21:31 ` [PATCH rdma-next V2 1/6] RDMA/core: Commonize RDMA IOCTL declarations location Leon Romanovsky
2016-08-23 21:31 ` [PATCH rdma-next V2 2/6] RDMA/core: Move legacy MAD IOCTL declarations to common file Leon Romanovsky
2016-08-23 21:31 ` [PATCH rdma-next V2 3/6] RDMA/hfi1: Avoid redeclaration error Leon Romanovsky
2016-08-23 21:31 ` [PATCH rdma-next V2 4/6] RDMA/core: Move HFI1 IOCTL declarations to common file Leon Romanovsky
2016-08-23 21:31 ` [PATCH rdma-next V2 5/6] RDMA/core: Rename RDMA magic number Leon Romanovsky
2016-08-23 21:31 ` [PATCH rdma-next V2 6/6] RDMA/core: Unify style of IOCTL commands Leon Romanovsky
[not found] ` <1471987907-6336-7-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-01 14:05 ` Dalessandro, Dennis
[not found] ` <1472738739.16467.8.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-01 16:20 ` Leon Romanovsky
[not found] ` <20160901162043.GD21847-2ukJVAZIZ/Y@public.gmane.org>
2016-09-01 16:54 ` Dalessandro, Dennis
2016-09-01 16:46 ` Jason Gunthorpe
[not found] ` <20160901164624.GC6479-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 16:55 ` Leon Romanovsky
[not found] ` <20160901165552.GE21847-2ukJVAZIZ/Y@public.gmane.org>
2016-09-01 17:04 ` Dalessandro, Dennis
2016-09-01 17:07 ` Jason Gunthorpe
[not found] ` <20160901170742.GA20098-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 17:09 ` Dalessandro, Dennis
[not found] ` <1472749767.16467.25.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-01 17:11 ` Jason Gunthorpe
[not found] ` <20160901171129.GB19982-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 17:17 ` Dalessandro, Dennis [this message]
[not found] ` <1472750241.16467.29.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-01 17:33 ` Jason Gunthorpe
[not found] ` <20160901173320.GB20472-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 17:52 ` Leon Romanovsky
[not found] ` <20160901175222.GF21847-2ukJVAZIZ/Y@public.gmane.org>
2016-09-06 21:03 ` ira.weiny
[not found] ` <20160906210313.GA24527-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-09-06 21:19 ` Jason Gunthorpe
[not found] ` <20160906211959.GA27106-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-07 23:06 ` ira.weiny
2016-09-07 5:55 ` Leon Romanovsky
[not found] ` <20160907055519.GT21847-2ukJVAZIZ/Y@public.gmane.org>
2016-09-07 23:55 ` ira.weiny
[not found] ` <20160907235508.GB4515-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-09-08 13:48 ` Leon Romanovsky
2016-09-01 17:02 ` Dalessandro, Dennis
2016-08-23 21:47 ` [PATCH rdma-next V2 0/6] Refactor RDMA IOCTL declarations Jason Gunthorpe
[not found] ` <20160823214759.GA16595-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-08-24 10:14 ` Leon Romanovsky
2016-09-01 11:17 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472750241.16467.29.camel@intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).