From mboxrd@z Thu Jan 1 00:00:00 1970 From: Knut Omang Subject: Re: [PATCH libibverbs 1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters Date: Thu, 01 Sep 2016 19:22:38 +0200 Message-ID: <1472750558.9410.230.camel@oracle.com> References: <1472713193-22397-1-git-send-email-knut.omang@oracle.com> <1472713193-22397-2-git-send-email-knut.omang@oracle.com> <20160901164939.GD6479@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160901164939.GD6479-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mukesh Kacker List-Id: linux-rdma@vger.kernel.org On Thu, 2016-09-01 at 10:49 -0600, Jason Gunthorpe wrote: > On Thu, Sep 01, 2016 at 08:59:51AM +0200, Knut Omang wrote: > > +++ b/src/libibverbs.map > > @@ -64,6 +64,7 @@ IBVERBS_1.0 { > > ibv_cmd_post_recv; > > ibv_cmd_post_srq_recv; > > ibv_cmd_create_ah; > > + ibv_cmd_create_ah_ex; > > I should also point out that this is not the proper way to use symbol > versions. Typically one would tag new symbols with the version number > of the release that introduces them, and not just keep re-using 1.0 > > I know we haven't been doing that, but perhaps we should start. Yes, I noticed the never changed 1.0 and tried just to follow the usage pattern ;-) Note that the best solution if we get a merged library repo would just be to eliminate it by folding the arguments into ibv_cmd_create_ah and make it similar to the other *create* functions. I added it only to avoid breaking vendor libraries. Knut > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html