Re: [PATCH 8/9] ib_uverbs: Support for kernel implementation of XRC

[Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Thu, 2016-09-01 at 20:16 -0600, Jason Gunthorpe wrote:
> On Fri, Sep 02, 2016 at 02:09:28AM +0200, Knut Omang wrote:
> 
> > +++ b/include/uapi/rdma/ib_user_verbs.h
> > @@ -725,6 +725,8 @@ struct ib_uverbs_send_wr {
> >  			__u32 reserved;
> >  		} ud;
> >  	} wr;
> > +	__u32 xrc_remote_srq_num;
> > +	__u32 reserved;
> >  };
> 
> Hum, how does compat work here? Isn't send_wr usually an array?

Thanks for pointing that out - you are quite right - this has the same issue as
the other 32 bit padding addition.

As the two patch set stands, both libibverbs and the kernel needs to be updated 
at the same time due to these end alignment issues.

Can we agree on that the patch itself is necessary to support vendor specific
extensions, and that the misaligment I fix here is a bug fix?

Then people can continue to evaluate the patch set assuming 
I can propose a solution to the  

old libibverbs - new kernel or
new libiverbs, old kernel

situations?

Thanks for the reviews!
Knut

> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html