linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH rdma-next V3 0/6]  Refactor RDMA IOCTL declarations
Date: Sun,  4 Sep 2016 14:30:29 +0300	[thread overview]
Message-ID: <1472988635-31463-1-git-send-email-leon@kernel.org> (raw)

Hi Doug,

This patch set refactors RDMA IOCTL declarations, unifies their
location, moves all current IOCTL exporters to one place and renames
them to fix the differences in coding style.

IOCTLs commands need to export the size of their data for their transfer
which is usually declared as a struct defined in relevant submodule.
These structures should be visible at the linkage stage.

There are number of possible solutions to overcome this limitations.

One of the options is to declare anonymous variable which will be visible
during the linkage. As a downside, such option won't allow direct use of
this header by other parts of code without their specific includes of
other logically unrelated submodules.

Another possible option will be to move declarations of that structures
to that common header file. Such move will cause to bloat this file
with different submodules declarations.

Our decision was to choose direct include of other exported files with
declarations of such structures to simplify future usage of this file.
There is no change for legacy applications and libraries.

Changes v2->v3:
 * Added Jason's Reviewed-by
 * Open-ceded ioctl indexes

Changes v0->v2 (v1 was skipped):
 * Update commit messages of patch number 3 and 6.

Available in the "topic/ioctl-header" topic branch of this git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git

Or for browsing:
https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/ioctl-header

Thanks

Leon Romanovsky (6):
  RDMA/core: Commonize RDMA IOCTL declarations location
  RDMA/core: Move legacy MAD IOCTL declarations to common file
  RDMA/hfi1: Avoid redeclaration error
  RDMA/core: Move HFI1 IOCTL declarations to common file
  RDMA/core: Rename RDMA magic number
  RDMA/core: Unify style of IOCTL commands

 include/uapi/rdma/Kbuild            |   1 +
 include/uapi/rdma/hfi/Kbuild        |   1 +
 include/uapi/rdma/hfi/hfi1_ioctl.h  | 173 +++++++++++++++++++++++++++++++++++
 include/uapi/rdma/hfi/hfi1_user.h   | 175 +-----------------------------------
 include/uapi/rdma/ib_user_mad.h     |  14 +--
 include/uapi/rdma/rdma_user_ioctl.h |  87 ++++++++++++++++++
 6 files changed, 264 insertions(+), 187 deletions(-)
 create mode 100644 include/uapi/rdma/hfi/hfi1_ioctl.h
 create mode 100644 include/uapi/rdma/rdma_user_ioctl.h

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2016-09-04 11:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04 11:30 Leon Romanovsky [this message]
     [not found] ` <1472988635-31463-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-04 11:30   ` [PATCH rdma-next V3 1/6] RDMA/core: Commonize RDMA IOCTL declarations location Leon Romanovsky
2016-09-04 11:30   ` [PATCH rdma-next V3 2/6] RDMA/core: Move legacy MAD IOCTL declarations to common file Leon Romanovsky
2016-09-04 11:30   ` [PATCH rdma-next V3 3/6] RDMA/hfi1: Avoid redeclaration error Leon Romanovsky
2016-09-04 11:30   ` [PATCH rdma-next V3 4/6] RDMA/core: Move HFI1 IOCTL declarations to common file Leon Romanovsky
     [not found]     ` <1472988635-31463-5-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-05  2:41       ` Jason Gunthorpe
     [not found]         ` <20160905024158.GE21542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-05  5:31           ` Leon Romanovsky
2016-09-04 11:30   ` [PATCH rdma-next V3 5/6] RDMA/core: Rename RDMA magic number Leon Romanovsky
2016-09-04 11:30   ` [PATCH rdma-next V3 6/6] RDMA/core: Unify style of IOCTL commands Leon Romanovsky
     [not found]     ` <1472988635-31463-7-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-05  2:42       ` Jason Gunthorpe
2016-09-05  5:33       ` Leon Romanovsky
     [not found]         ` <20160905053342.GW21847-2ukJVAZIZ/Y@public.gmane.org>
2016-09-23 17:31           ` Doug Ledford
2016-09-06 13:00       ` Dalessandro, Dennis
     [not found]         ` <1473166808.2465.9.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-07  7:01           ` Leon Romanovsky
     [not found]             ` <20160907070109.GC3639-2ukJVAZIZ/Y@public.gmane.org>
2016-09-23 17:32               ` Doug Ledford
2016-09-23 17:34   ` [PATCH rdma-next V3 0/6] Refactor RDMA IOCTL declarations Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472988635-31463-1-git-send-email-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).