public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: David Chang <dchang-IBi9RG/b67k@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] IB/mlx5: Fix decision to avoid using MAD_IFC command in ISSI > 0 mode
Date: Wed,  7 Sep 2016 15:23:10 +0800	[thread overview]
Message-ID: <1473232990-22766-1-git-send-email-dchang@suse.com> (raw)

When using MAD_IFC command, we should also consider avoiding in
ISSI > 0 mode, otherwise most of the MAD_IFC command features
are deprecated and cannot be used.

Fixes: d603c809ef91 ("IB/mlx5: Fix decision on using MAD_IFC")
Reported-by: Sujith Pandel <sujith_pandel-8PEkshWhKlo@public.gmane.org>
Signed-off-by: David Chang <dchang-IBi9RG/b67k@public.gmane.org>
---
 drivers/infiniband/hw/mlx5/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 1b4094baa2de..0796fb2b04f1 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -288,7 +288,8 @@ __be16 mlx5_get_roce_udp_sport(struct mlx5_ib_dev *dev, u8 port_num,
 
 static int mlx5_use_mad_ifc(struct mlx5_ib_dev *dev)
 {
-	return !MLX5_CAP_GEN(dev->mdev, ib_virt);
+	return !dev->mdev->issi &&
+		!MLX5_CAP_GEN(dev->mdev, ib_virt);
 }
 
 enum {
-- 
2.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2016-09-07  7:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  7:23 David Chang [this message]
     [not found] ` <1473232990-22766-1-git-send-email-dchang-IBi9RG/b67k@public.gmane.org>
2016-09-07  7:40   ` [PATCH] IB/mlx5: Fix decision to avoid using MAD_IFC command in ISSI > 0 mode Or Gerlitz
2016-09-08 14:07   ` Leon Romanovsky
     [not found]     ` <20160908140752.GN18398-2ukJVAZIZ/Y@public.gmane.org>
2016-09-08 15:24       ` Or Gerlitz
2016-09-09  2:55       ` David Chang
     [not found]         ` <20160909025527.GC3042-5oAczMR2RyTI588T0lkTTQ@public.gmane.org>
2016-09-09 10:39           ` Or Gerlitz
     [not found]             ` <CAJ3xEMhK4e9tD3awWt0uFdg=ptai3c5kCeDUmOBudQ2nu46rRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-10  6:10               ` David Chang
2016-09-10  7:47           ` Leon Romanovsky
     [not found]             ` <20160910074719.GG6415-2ukJVAZIZ/Y@public.gmane.org>
2016-09-11  7:15               ` Leon Romanovsky
     [not found]                 ` <9293c685-7ce9-be56-89fa-a5562a703b81@mellanox.com>
     [not found]                   ` <9293c685-7ce9-be56-89fa-a5562a703b81-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-12  4:29                     ` Leon Romanovsky
     [not found]                 ` <20160911071542.GH6415-2ukJVAZIZ/Y@public.gmane.org>
2016-09-12  4:40                   ` David Chang
2016-09-12  6:28                   ` Or Gerlitz
     [not found]                     ` <CAJ3xEMiZ5dssHMW9ypN_86PUOQxuwaRB0G1iv5=Jbzc9w76cLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-12  6:46                       ` Leon Romanovsky
2016-09-13  1:40                   ` David Chang
     [not found]                     ` <20160913014023.GI3042-5oAczMR2RyTI588T0lkTTQ@public.gmane.org>
2016-09-13  5:52                       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473232990-22766-1-git-send-email-dchang@suse.com \
    --to=dchang-ibi9rg/b67k@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox