linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mukesh Kacker
	<mukesh.kacker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH libibverbs v2 1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters
Date: Mon, 19 Sep 2016 05:51:03 +0200	[thread overview]
Message-ID: <1474257063.20134.103.camel@oracle.com> (raw)
In-Reply-To: <20160919030122.GA23152-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

On Sun, 2016-09-18 at 21:01 -0600, Jason Gunthorpe wrote:
> On Sat, Sep 17, 2016 at 05:59:11AM +0200, Knut Omang wrote:
> > @@ -118,5 +118,9 @@ IBVERBS_1.1 {
> >  		ibv_cmd_create_qp_ex2;
> >  		ibv_cmd_open_qp;
> >  		ibv_cmd_rereg_mr;
> > +};
> >  
> > +IBVERBS_1.3 {
> > +	global:
> > +		ibv_cmd_create_ah_ex;
> >  } IBVERBS_1.0;
> 
> This will probably end up being 1.4, and the 'tree' structure is
> wrong, do not move this line:
> 
> >  } IBVERBS_1.0;

I was a bit concerned about the "structure", but ultimately decided to
follow the pattern since I could not find any documentation with this syntax
(which is probably because it is not supported?)

As far as I can see, the final IBVERBS_1.0 does not have any effect at all, 
the symbol output seems identical, so it should probably be removed, but
maybe as a separate patch, with explanation?

Knut
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-09-19  3:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17  3:59 [PATCH libibverbs v2 0/3] SIF related libibverbs patches Knut Omang
     [not found] ` <cover.0e6854f557aa8aa6ed7681cdf58397ef4f106505.1474063039.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-17  3:59   ` [PATCH libibverbs v2 1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters Knut Omang
     [not found]     ` <5cc0157c0f05701d8cb1334e6ee11e1e7be6fa24.1474063039.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-19  3:01       ` Jason Gunthorpe
     [not found]         ` <20160919030122.GA23152-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-19  3:51           ` Knut Omang [this message]
     [not found]             ` <1474257063.20134.103.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-19  4:03               ` Knut Omang
2016-09-19  4:08               ` Jason Gunthorpe
     [not found]                 ` <20160919040854.GA28241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-19  4:29                   ` Knut Omang
     [not found]                     ` <1474259364.20134.114.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-19  4:36                       ` Knut Omang
     [not found]                         ` <1474259792.20134.117.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-19 16:59                           ` Jason Gunthorpe
     [not found]                             ` <20160919165942.GB11836-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-20  4:42                               ` Knut Omang
2016-09-17  3:59   ` [PATCH libibverbs v2 2/3] Add padding to get proper end alignment of ibv_reg_mr_resp Knut Omang
2016-09-17  3:59   ` [PATCH libibverbs v2 3/3] Provide remote XRC SRQ number in kernel post_send Knut Omang
     [not found]     ` <d57e9dc45f6f4aed9dfb86a498226dab99e530a4.1474063039.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-19  5:29       ` Leon Romanovsky
     [not found]         ` <20160919052911.GF3273-2ukJVAZIZ/Y@public.gmane.org>
2016-09-19  9:12           ` Knut Omang
     [not found]             ` <1474276356.24045.93.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-20 10:18               ` Leon Romanovsky
     [not found]                 ` <20160920101839.GF26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 10:43                   ` Knut Omang
     [not found]                     ` <1474368210.8837.3.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-20 11:01                       ` Leon Romanovsky
     [not found]                         ` <20160920110115.GJ26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 11:08                           ` Knut Omang
     [not found]                             ` <1474369715.8837.19.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-20 12:17                               ` Leon Romanovsky
     [not found]                                 ` <20160920121741.GL26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 13:38                                   ` Knut Omang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474257063.20134.103.camel@oracle.com \
    --to=knut.omang-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mukesh.kacker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).