Re: [PATCH 2/9] Remove HAVE_VALGRIND_MEMCHECK_H/INCLUDE_VALGRIND

Bart Van Assche
2016-09-30T16:49:15Z

On 09/29/2016 01:47 PM, Jason Gunthorpe wrote:
> The cmake build system guarantees that valgrind/memcheck.h is present.
> If the system does not have it, or valgrind is disabled, then it is
> replaced with a dummy header full of empty stubs.
>
> Thus all the copy&paste boiler plate is consolidated into buildlib.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
> buildlib/config.h.in | 4 ----
> libibcm/src/cm.c | 11 +----------
> libibumad/src/umad.c | 14 +-------------
> libibverbs/src/ibverbs.h | 14 +-------------
> libmlx4/src/mlx4.h | 18 +-----------------
> libmlx5/src/mlx5.h | 18 +-----------------
> libmthca/src/mthca.h | 18 +-----------------
> librdmacm/src/cma.h | 11 +----------
> srp_daemon/srp_daemon/srp_daemon.h | 5 -----
> 9 files changed, 7 insertions(+), 106 deletions(-)

For the srp_daemon changes:

Reviewed-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>