Re: [PATCH 2/9] Remove HAVE_VALGRIND_MEMCHECK_H/INCLUDE_VALGRIND

Bart Van Assche
2016-09-29T23:48:25Z

On 09/29/2016 03:34 PM, Jason Gunthorpe wrote:
> On Thu, Sep 29, 2016 at 02:01:26PM -0700, Bart Van Assche wrote:
>> Independent of this patch: Valgrind has a stable ABI so I propose to add a
>> copy of the memcheck.h header file to the rdma-core source tree. Many other
>> open source projects already do this.
>
> Interesting idea, what do you see as the benefit?

Hello Jason,

That would allow to annotate rdma-core code correctly for Valgrind
without introducing a dependency on the valgrind-devel package. As you
know most Linux distro's by default do not install the valgrind-devel
package.

Bart.