Re: [PATCH 2/9] Remove HAVE_VALGRIND_MEMCHECK_H/INCLUDE_VALGRIND

Jason Gunthorpe
2016-09-29T22:34:15Z

On Thu, Sep 29, 2016 at 02:01:26PM -0700, Bart Van Assche wrote:

> Independent of this patch: Valgrind has a stable ABI so I propose to add a
> copy of the memcheck.h header file to the rdma-core source tree. Many other
> open source projects already do this.

Interesting idea, what do you see as the benefit?

FWIW, I haven't had any problems getting the valgrind headers on any
supported distro.

I think I'd rather make the absence of valgrind a hard error (right
now cmake makes a warning in the summary) than worry about another
copied header...

Jason