linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	Bart Van Assche
	<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
	Faisal Latif
	<faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Mike Marciniszyn
	<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Dennis Dalessandro a
	<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Dave Goodell <dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH rdma-next V1 00/17] Remove debug prints after allocation failure
Date: Thu,  3 Nov 2016 16:44:08 +0200	[thread overview]
Message-ID: <1478184265-9620-1-git-send-email-leon@kernel.org> (raw)

Hi Doug and all,

This is semantic cleanup of infiniband stack from printks immediately
after allocation failure. It doesn't get rid from all printks, but only from
the ones which were found by the following grep construction.

➜  linux-rdma git:(topic/clean-alloc-prints) grep -rI "[k|v][m|z|c]alloc(" drivers/infiniband/* -A5 | grep "n\""

The patchset consists from the 16 almost identical patches and from one fix
which was discovered during the cleanup work.

The fix is presented in the patch "IB/core: Release allocated memory in cache setup failure"

Available in the "topic/clean-alloc-prints" topic branch of this git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git
Or for browsing:
https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/clean-alloc-prints

CC: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
CC: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
CC: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
CC: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
CC: Faisal Latif <faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
CC: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
CC: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
CC: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
CC: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>a
CC: Dave Goodell <dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>

Changes v0 -> v1:
 * Patch 17: Return brackets removed by mistake.

Leon Romanovsky (17):
  IB/mad: Remove debug prints after allocation failure
  IB/core: Remove debug prints after allocation failure
  IB/core: Release allocated memory in cache setup failure
  IB/mlx4: Remove debug prints after allocation failure
  IB/mlx5: Remove debug prints after allocation failure
  IB/hfi1: Remove debug prints after allocation failure
  IB/cxgb3: Remove debug prints after allocation failure
  IB/cxgb4: Remove debug prints after allocation failure
  IB/i40iw: Remove debug prints after allocation failure
  IB/qib: Remove debug prints after allocation failure
  IB/nes: Remove debug prints after allocation failure
  IB/mthca: Remove debug prints after allocation failure
  IB/usninc: Remove and fix debug prints after allocation failure
  IB/ocrdma: Remove and fix debug prints after allocation failure
  IB/rxe: Remove and fix debug prints after allocation failure
  IB/isert: Remove and fix debug prints after allocation failure
  IB/ipoib: Remove and fix debug prints after allocation failure

 drivers/infiniband/core/agent.c               |  1 -
 drivers/infiniband/core/cache.c               | 16 ++++-----
 drivers/infiniband/core/device.c              |  5 +--
 drivers/infiniband/core/fmr_pool.c            |  1 -
 drivers/infiniband/core/iwpm_msg.c            |  1 -
 drivers/infiniband/core/iwpm_util.c           | 12 +++----
 drivers/infiniband/core/mad.c                 | 40 ++++-------------------
 drivers/infiniband/core/roce_gid_mgmt.c       | 21 ++++--------
 drivers/infiniband/hw/cxgb3/cxio_dbg.c        | 20 +++++-------
 drivers/infiniband/hw/cxgb4/device.c          |  4 ---
 drivers/infiniband/hw/hfi1/pio.c              |  1 -
 drivers/infiniband/hw/i40iw/i40iw_cm.c        |  2 --
 drivers/infiniband/hw/i40iw/i40iw_main.c      |  5 ++-
 drivers/infiniband/hw/i40iw/i40iw_verbs.c     |  1 -
 drivers/infiniband/hw/mlx4/alias_GUID.c       |  4 +--
 drivers/infiniband/hw/mlx4/cm.c               |  4 +--
 drivers/infiniband/hw/mlx4/mad.c              |  9 ++---
 drivers/infiniband/hw/mlx4/main.c             | 16 ++-------
 drivers/infiniband/hw/mlx4/mcg.c              |  5 +--
 drivers/infiniband/hw/mlx5/srq.c              |  2 --
 drivers/infiniband/hw/mthca/mthca_reset.c     |  4 ---
 drivers/infiniband/hw/nes/nes.c               |  1 -
 drivers/infiniband/hw/nes/nes_cm.c            |  4 +--
 drivers/infiniband/hw/nes/nes_hw.c            |  6 ++--
 drivers/infiniband/hw/nes/nes_mgt.c           | 10 ++----
 drivers/infiniband/hw/nes/nes_verbs.c         |  4 ---
 drivers/infiniband/hw/ocrdma/ocrdma_hw.c      |  5 ++-
 drivers/infiniband/hw/ocrdma/ocrdma_stats.c   |  4 +--
 drivers/infiniband/hw/qib/qib_diag.c          |  6 +---
 drivers/infiniband/hw/qib/qib_eeprom.c        |  6 +---
 drivers/infiniband/hw/qib/qib_iba6120.c       |  8 +----
 drivers/infiniband/hw/qib/qib_iba7220.c       |  8 +----
 drivers/infiniband/hw/qib/qib_iba7322.c       | 22 +++----------
 drivers/infiniband/hw/qib/qib_init.c          | 47 +++++----------------------
 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 10 +-----
 drivers/infiniband/hw/usnic/usnic_vnic.c      | 22 ++++---------
 drivers/infiniband/sw/rxe/rxe_pool.c          |  1 -
 drivers/infiniband/ulp/ipoib/ipoib_cm.c       |  8 +----
 drivers/infiniband/ulp/ipoib/ipoib_ib.c       |  5 +--
 drivers/infiniband/ulp/ipoib/ipoib_main.c     |  5 +--
 drivers/infiniband/ulp/isert/ib_isert.c       | 23 ++++---------
 41 files changed, 84 insertions(+), 295 deletions(-)

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2016-11-03 14:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 14:44 Leon Romanovsky [this message]
     [not found] ` <1478184265-9620-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-11-03 14:44   ` [PATCH rdma-next V1 01/17] IB/mad: Remove debug prints after allocation failure Leon Romanovsky
     [not found]     ` <1478184265-9620-2-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-12-16  3:43       ` ira.weiny
2016-11-03 14:44   ` [PATCH rdma-next V1 02/17] IB/core: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 03/17] IB/core: Release allocated memory in cache setup failure Leon Romanovsky
     [not found]     ` <1478184265-9620-4-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-12-16  3:42       ` ira.weiny
     [not found]         ` <20161216034218.GA12582-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-12-16  4:27           ` Jason Gunthorpe
     [not found]             ` <20161216042743.GD3797-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-18  7:41               ` Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 04/17] IB/mlx4: Remove debug prints after allocation failure Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 05/17] IB/mlx5: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 06/17] IB/hfi1: " Leon Romanovsky
     [not found]     ` <1478184265-9620-7-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-11-12  4:04       ` Dalessandro, Dennis
     [not found]         ` <1478923438.2458.9.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-03 18:31           ` Doug Ledford
2016-11-03 14:44   ` [PATCH rdma-next V1 07/17] IB/cxgb3: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 08/17] IB/cxgb4: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 09/17] IB/i40iw: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 10/17] IB/qib: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 11/17] IB/nes: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 12/17] IB/mthca: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 13/17] IB/usninc: Remove and fix " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 14/17] IB/ocrdma: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 15/17] IB/rxe: " Leon Romanovsky
2016-11-03 14:44   ` [PATCH rdma-next V1 16/17] IB/isert: " Leon Romanovsky
     [not found]     ` <1478184265-9620-17-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-11-03 21:24       ` Sagi Grimberg
2016-11-03 14:44   ` [PATCH rdma-next V1 17/17] IB/ipoib: " Leon Romanovsky
2016-12-03 18:30   ` [PATCH rdma-next V1 00/17] Remove " Doug Ledford
2016-12-16  4:04   ` ira.weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478184265-9620-1-git-send-email-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).