From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 1/3] IB/srp: allocate ib_qp_attr on the stack
Date: Wed, 28 Dec 2016 11:38:26 +0000 [thread overview]
Message-ID: <1482925088.6713.2.camel@sandisk.com> (raw)
In-Reply-To: <1482922813-8392-2-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Wed, 2016-12-28 at 13:00 +0200, Max Gurtovoy wrote:
> No reason to allocate it dynamically.
The patch description is not correct. The reason struct ib_qp_attr is
allocated on the stack is to keep stack usage low, something that is
important in kernel code.
Bart.
next prev parent reply other threads:[~2016-12-28 11:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 11:00 [PATCH 0/3] srp/srpt - some useful patches Max Gurtovoy
[not found] ` <1482922813-8392-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-12-28 11:00 ` [PATCH 1/3] IB/srp: allocate ib_qp_attr on the stack Max Gurtovoy
[not found] ` <1482922813-8392-2-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-12-28 11:14 ` Yuval Shaia
2016-12-28 11:33 ` Max Gurtovoy
2016-12-28 11:38 ` Bart Van Assche [this message]
2016-12-28 11:00 ` [PATCH 2/3] IB/srpt: " Max Gurtovoy
[not found] ` <1482922813-8392-3-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-12-28 11:06 ` Yuval Shaia
2016-12-28 11:38 ` Max Gurtovoy
2016-12-28 11:39 ` Bart Van Assche
2016-12-28 12:57 ` Leon Romanovsky
2016-12-28 11:00 ` [PATCH 3/3] IB/srpt: fix compilation warning Max Gurtovoy
[not found] ` <1482922813-8392-4-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-12-28 11:18 ` Yuval Shaia
2016-12-28 11:41 ` Bart Van Assche
[not found] ` <1482925264.6713.5.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-12-28 11:44 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482925088.6713.2.camel@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox