Missing Patches in Linux Kernel RDMA

Missing Patches in Linux Kernel RDMA

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

Hi Doug,

While reviewing patches on mailing list, I was amazed to see
patches accepted before, marked such in patchworks but don't
exist in the Linus's tree.

The first patch which brought my attention was Christoph's change
"IB: merge struct ib_device_attr into struct ib_device" [1]. The other
missed patches were from our pre-ABI series "Refactor RDMA IOCTL
declarations" [2, 3].

I'm adding to CC major contributors to this subsystem, since I don't know
if any other patches are missing too and don't know how to check it without
doing full compare of Linus's tree with linux-rdma patchworks.

However for these 7 patches, can you please grab them from patchworks again
and resubmit?

Thanks

[1] https://patchwork.kernel.org/patch/7372541/
[2] https://www.spinics.net/lists/linux-rdma/msg39954.html
[3] https://patchwork.kernel.org/patch/9312603/
    https://patchwork.kernel.org/patch/9312593/
    https://patchwork.kernel.org/patch/9312597/
    https://patchwork.kernel.org/patch/9312601/
    https://patchwork.kernel.org/patch/9312595/
    https://patchwork.kernel.org/patch/9312599/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Christoph Hellwig]

On Tue, Jan 10, 2017 at 04:30:18PM +0200, Leon Romanovsky wrote:
> The first patch which brought my attention was Christoph's change
> "IB: merge struct ib_device_attr into struct ib_device" [1].

Doug decided to not kill off ib_device_attr entirely and just embedded
it into the ib_device structure.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Missing Patches in Linux Kernel RDMA

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On Tue, 2017-01-10 at 15:36 +0100, Christoph Hellwig wrote:
> On Tue, Jan 10, 2017 at 04:30:18PM +0200, Leon Romanovsky wrote:
> > 
> > The first patch which brought my attention was Christoph's change
> > "IB: merge struct ib_device_attr into struct ib_device" [1].
> 
> Doug decided to not kill off ib_device_attr entirely and just
> embedded
> it into the ib_device structure.

Correct, I believe it was Or's patch that did that.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

On Tue, Jan 10, 2017 at 11:51:35AM -0500, Doug Ledford wrote:
> On Tue, 2017-01-10 at 15:36 +0100, Christoph Hellwig wrote:
> > On Tue, Jan 10, 2017 at 04:30:18PM +0200, Leon Romanovsky wrote:
> > >
> > > The first patch which brought my attention was Christoph's change
> > > "IB: merge struct ib_device_attr into struct ib_device" [1].
> >
> > Doug decided to not kill off ib_device_attr entirely and just
> > embedded
> > it into the ib_device structure.
>
> Correct, I believe it was Or's patch that did that.

The original patch did more than just put all data into
ib_device. It removed the redundant parameter
(struct ib_device_attr *device_attr) from query_device().

Current code:
1883 struct ib_device {
....
1930         int                        (*query_device)(struct ib_device *device,
1931                                                    struct ib_device_attr *device_attr,
1932                                                    struct ib_udata *udata);

Do we want to continue that road and complete the cleanup?

>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG KeyID: B826A3330E572FDD
>    
> Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

On Tue, 2017-01-10 at 20:50 +0200, Leon Romanovsky wrote:
> On Tue, Jan 10, 2017 at 11:51:35AM -0500, Doug Ledford wrote:
> > 
> > On Tue, 2017-01-10 at 15:36 +0100, Christoph Hellwig wrote:
> > > 
> > > On Tue, Jan 10, 2017 at 04:30:18PM +0200, Leon Romanovsky wrote:
> > > > 
> > > > 
> > > > The first patch which brought my attention was Christoph's
> > > > change
> > > > "IB: merge struct ib_device_attr into struct ib_device" [1].
> > > 
> > > Doug decided to not kill off ib_device_attr entirely and just
> > > embedded
> > > it into the ib_device structure.
> > 
> > Correct, I believe it was Or's patch that did that.
> 
> The original patch did more than just put all data into
> ib_device. It removed the redundant parameter
> (struct ib_device_attr *device_attr) from query_device().
> 
> Current code:
> 1883 struct ib_device {
> ....
> 1930         int                        (*query_device)(struct
> ib_device *device,
> 1931                                                    struct
> ib_device_attr *device_attr,
> 1932                                                    struct
> ib_udata *udata);
> 
> Do we want to continue that road and complete the cleanup?

Feel free to submit an additional patch.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]

On Tue, 2017-01-10 at 16:30 +0200, Leon Romanovsky wrote:
> Hi Doug,
> 
> While reviewing patches on mailing list, I was amazed to see
> patches accepted before, marked such in patchworks but don't
> exist in the Linus's tree.
> 
> The first patch which brought my attention was Christoph's change
> "IB: merge struct ib_device_attr into struct ib_device" [1]. The
> other
> missed patches were from our pre-ABI series "Refactor RDMA IOCTL
> declarations" [2, 3].

I obviously had these in my tree at one point, the last message I wrote
in response to the 6th patch makes that very clear.  But, the patch
series is indeed missing.  I must have failed to merge it some time,
but thought I did merge it and moved it to my post-merge area which
then eventually gets removed.  I'll have to re-grab them.

> I'm adding to CC major contributors to this subsystem, since I don't
> know
> if any other patches are missing too and don't know how to check it
> without
> doing full compare of Linus's tree with linux-rdma patchworks.
> 
> However for these 7 patches, can you please grab them from patchworks
> again
> and resubmit?
> 
> Thanks
> 
> [1] https://patchwork.kernel.org/patch/7372541/
> [2] https://www.spinics.net/lists/linux-rdma/msg39954.html
> [3] https://patchwork.kernel.org/patch/9312603/
>     https://patchwork.kernel.org/patch/9312593/
>     https://patchwork.kernel.org/patch/9312597/
>     https://patchwork.kernel.org/patch/9312601/
>     https://patchwork.kernel.org/patch/9312595/
>     https://patchwork.kernel.org/patch/9312599/
-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 2089 bytes --]

On Tue, Jan 10, 2017 at 11:53:58AM -0500, Doug Ledford wrote:
> On Tue, 2017-01-10 at 16:30 +0200, Leon Romanovsky wrote:
> > Hi Doug,
> >
> > While reviewing patches on mailing list, I was amazed to see
> > patches accepted before, marked such in patchworks but don't
> > exist in the Linus's tree.
> >
> > The first patch which brought my attention was Christoph's change
> > "IB: merge struct ib_device_attr into struct ib_device" [1]. The
> > other
> > missed patches were from our pre-ABI series "Refactor RDMA IOCTL
> > declarations" [2, 3].
>
> I obviously had these in my tree at one point, the last message I wrote
> in response to the 6th patch makes that very clear.  But, the patch
> series is indeed missing.  I must have failed to merge it some time,
> but thought I did merge it and moved it to my post-merge area which
> then eventually gets removed.  I'll have to re-grab them.

Thanks,
Can you please publish official branch with them?
Matan is going to send ABI patches very soon (they passed our
verification) and he needs to be based on them.

>
> > I'm adding to CC major contributors to this subsystem, since I don't
> > know
> > if any other patches are missing too and don't know how to check it
> > without
> > doing full compare of Linus's tree with linux-rdma patchworks.
> >
> > However for these 7 patches, can you please grab them from patchworks
> > again
> > and resubmit?
> >
> > Thanks
> >
> > [1] https://patchwork.kernel.org/patch/7372541/
> > [2] https://www.spinics.net/lists/linux-rdma/msg39954.html
> > [3] https://patchwork.kernel.org/patch/9312603/
> >     https://patchwork.kernel.org/patch/9312593/
> >     https://patchwork.kernel.org/patch/9312597/
> >     https://patchwork.kernel.org/patch/9312601/
> >     https://patchwork.kernel.org/patch/9312595/
> >     https://patchwork.kernel.org/patch/9312599/
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG KeyID: B826A3330E572FDD
>    
> Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 2577 bytes --]

On Tue, 2017-01-10 at 20:28 +0200, Leon Romanovsky wrote:
> On Tue, Jan 10, 2017 at 11:53:58AM -0500, Doug Ledford wrote:
> > 
> > On Tue, 2017-01-10 at 16:30 +0200, Leon Romanovsky wrote:
> > > 
> > > Hi Doug,
> > > 
> > > While reviewing patches on mailing list, I was amazed to see
> > > patches accepted before, marked such in patchworks but don't
> > > exist in the Linus's tree.
> > > 
> > > The first patch which brought my attention was Christoph's change
> > > "IB: merge struct ib_device_attr into struct ib_device" [1]. The
> > > other
> > > missed patches were from our pre-ABI series "Refactor RDMA IOCTL
> > > declarations" [2, 3].
> > 
> > I obviously had these in my tree at one point, the last message I
> > wrote
> > in response to the 6th patch makes that very clear.  But, the patch
> > series is indeed missing.  I must have failed to merge it some
> > time,
> > but thought I did merge it and moved it to my post-merge area which
> > then eventually gets removed.  I'll have to re-grab them.
> 
> Thanks,
> Can you please publish official branch with them?

They are in my k.o/for-4.11 branch.

> Matan is going to send ABI patches very soon (they passed our
> verification) and he needs to be based on them.
> 
> > 
> > 
> > > 
> > > I'm adding to CC major contributors to this subsystem, since I
> > > don't
> > > know
> > > if any other patches are missing too and don't know how to check
> > > it
> > > without
> > > doing full compare of Linus's tree with linux-rdma patchworks.
> > > 
> > > However for these 7 patches, can you please grab them from
> > > patchworks
> > > again
> > > and resubmit?
> > > 
> > > Thanks
> > > 
> > > [1] https://patchwork.kernel.org/patch/7372541/
> > > [2] https://www.spinics.net/lists/linux-rdma/msg39954.html
> > > [3] https://patchwork.kernel.org/patch/9312603/
> > >     https://patchwork.kernel.org/patch/9312593/
> > >     https://patchwork.kernel.org/patch/9312597/
> > >     https://patchwork.kernel.org/patch/9312601/
> > >     https://patchwork.kernel.org/patch/9312595/
> > >     https://patchwork.kernel.org/patch/9312599/
> > --
> > Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >     GPG KeyID: B826A3330E572FDD
> >    
> > Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57
> > 2FDD
> 
> 
-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Missing Patches in Linux Kernel RDMA

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 2755 bytes --]

On Tue, Jan 10, 2017 at 01:52:57PM -0500, Doug Ledford wrote:
> On Tue, 2017-01-10 at 20:28 +0200, Leon Romanovsky wrote:
> > On Tue, Jan 10, 2017 at 11:53:58AM -0500, Doug Ledford wrote:
> > >
> > > On Tue, 2017-01-10 at 16:30 +0200, Leon Romanovsky wrote:
> > > >
> > > > Hi Doug,
> > > >
> > > > While reviewing patches on mailing list, I was amazed to see
> > > > patches accepted before, marked such in patchworks but don't
> > > > exist in the Linus's tree.
> > > >
> > > > The first patch which brought my attention was Christoph's change
> > > > "IB: merge struct ib_device_attr into struct ib_device" [1]. The
> > > > other
> > > > missed patches were from our pre-ABI series "Refactor RDMA IOCTL
> > > > declarations" [2, 3].
> > >
> > > I obviously had these in my tree at one point, the last message I
> > > wrote
> > > in response to the 6th patch makes that very clear.  But, the patch
> > > series is indeed missing.  I must have failed to merge it some
> > > time,
> > > but thought I did merge it and moved it to my post-merge area which
> > > then eventually gets removed.  I'll have to re-grab them.
> >
> > Thanks,
> > Can you please publish official branch with them?
>
> They are in my k.o/for-4.11 branch.

Thanks Doug.

>
> > Matan is going to send ABI patches very soon (they passed our
> > verification) and he needs to be based on them.
> >
> > >
> > >
> > > >
> > > > I'm adding to CC major contributors to this subsystem, since I
> > > > don't
> > > > know
> > > > if any other patches are missing too and don't know how to check
> > > > it
> > > > without
> > > > doing full compare of Linus's tree with linux-rdma patchworks.
> > > >
> > > > However for these 7 patches, can you please grab them from
> > > > patchworks
> > > > again
> > > > and resubmit?
> > > >
> > > > Thanks
> > > >
> > > > [1] https://patchwork.kernel.org/patch/7372541/
> > > > [2] https://www.spinics.net/lists/linux-rdma/msg39954.html
> > > > [3] https://patchwork.kernel.org/patch/9312603/
> > > >     https://patchwork.kernel.org/patch/9312593/
> > > >     https://patchwork.kernel.org/patch/9312597/
> > > >     https://patchwork.kernel.org/patch/9312601/
> > > >     https://patchwork.kernel.org/patch/9312595/
> > > >     https://patchwork.kernel.org/patch/9312599/
> > > --
> > > Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > >     GPG KeyID: B826A3330E572FDD
> > >    
> > > Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57
> > > 2FDD
> >
> >
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG KeyID: B826A3330E572FDD
>    
> Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]