Re: [PATCH 1/4] IB/core: add port state cache

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3768 bytes --]

On Mon, 2016-12-12 at 12:43 +0100, Jinpu Wang wrote:
> From fc80c1730d94a38934c5c60f9b9561745723dfd9 Mon Sep 17 00:00:00
> 2001
> From: Jack Wang <jinpu.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> Date: Mon, 12 Dec 2016 09:52:42 +0100
> Subject: [PATCH 1/4] IB/core: add port state cache
> 
> We need a port state cache in ib_core, later we will use in rdma_cm.

All of these patches were mangled.  Their tabs were converted to
spaces, they had line wraps where they shouldn't, etc.

Please don't send them using an email program, it obviously isn't
working in your case.  I strongly recommend using "git send-email" to
send the series.

Before resending, add a comment to the first about the memory being
freed during the release operation, that will forestall any more
questions about memory leaks.  Also capture Sean Hefty's ack on all of
your patches.

I'm ready to take them, I just need you to rework them.  Thanks.

> Signed-off-by: Jack Wang <jinpu.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> Reviewed-by: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> ---
>  drivers/infiniband/core/cache.c | 9 ++++++++-
>  include/rdma/ib_verbs.h         | 1 +
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/cache.c
> b/drivers/infiniband/core/cache.c
> index 1a2984c..025db27 100644
> --- a/drivers/infiniband/core/cache.c
> +++ b/drivers/infiniband/core/cache.c
> @@ -1109,6 +1109,8 @@ static void ib_cache_update(struct ib_device
> *device,
>      }
> 
>      device->cache.lmc_cache[port - rdma_start_port(device)] =
> tprops->lmc;
> +    device->cache.port_state_cache[port - rdma_start_port(device)] =
> +        tprops->state;
> 
>      write_unlock_irq(&device->cache.lock);
> 
> @@ -1168,7 +1170,11 @@ int ib_cache_setup_one(struct ib_device
> *device)
>                        (rdma_end_port(device) -
>                         rdma_start_port(device) + 1),
>                        GFP_KERNEL);
> -    if (!device->cache.pkey_cache ||
> +    device->cache.port_state_cache = kmalloc(sizeof
> *device->cache.port_state_cache *
> +                      (rdma_end_port(device) -
> +                       rdma_start_port(device) + 1),
> +                      GFP_KERNEL);
> +    if (!device->cache.pkey_cache || !device->cache.port_state_cache 
> ||
>          !device->cache.lmc_cache) {
>          pr_warn("Couldn't allocate cache for %s\n", device->name);
>          return -ENOMEM;
> @@ -1213,6 +1219,7 @@ void ib_cache_release_one(struct ib_device
> *device)
>      gid_table_release_one(device);
>      kfree(device->cache.pkey_cache);
>      kfree(device->cache.lmc_cache);
> +    kfree(device->cache.port_state_cache);
>  }
> 
>  void ib_cache_cleanup_one(struct ib_device *device)
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 5ad43a4..a167ae0 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1761,6 +1761,7 @@ struct ib_cache {
>      struct ib_pkey_cache  **pkey_cache;
>      struct ib_gid_table   **gid_cache;
>      u8                     *lmc_cache;
> +    enum ib_port_state     *port_state_cache;
>  };
> 
>  struct ib_dma_mapping_ops {
> -- 
> 2.7.4
> 
> 
-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]