public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jinpu Wang <jinpu.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	"Hefty,
	Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Subject: Re: [PATCHv2 0/4] IB cache port state, use it when resolve address
Date: Thu, 12 Jan 2017 23:02:03 -0500	[thread overview]
Message-ID: <1484280123.123135.55.camel@redhat.com> (raw)
In-Reply-To: <CAMGffE=xA9GMMWAKPMzAtWxHBSbBVft04LjB+fhc0mLRjmEXfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]

On Wed, 2017-01-11 at 13:26 +0100, Jinpu Wang wrote:
> On Mon, Jan 2, 2017 at 1:15 PM, Jinpu Wang <jinpu.wang@profitbricks.c
> om> wrote:
> > 
> > Hi Folks,
> > 
> > This is my forth attempt to fix rdma_revolve_addr may resolve to
> > first
> > port even it's down[1].
> > 
> > As Jason and Hefty suggested, I now cache port_state in ib_core,
> > and
> > update cma_resolve_ib_dev and cma_bind_loopback to use it.
> > 
> > 0001-IB-core-add-port-state-cache.patch
> > 0002-IB-core-export-ib_get_cached_port_state.patch
> > 0003-cma-resolve-to-first-active-ib-port.patch
> > 0004-cma-use-cached-port-state-when-bind-loopback.patch
> > 
> > [1]http://marc.info/?l=linux-rdma&m=148102306632521&w=2
> > 
> > Changes from v1:
> > - Add Hefty's Acked-by.
> > - rebase on Doug's rdma/k.o/for-4.10 (commit
> > 5cc8fabc5e4c588c75a5ec21423e7c3425f69f48)
> > - fix a mem leak in ib_cache_setup_one in error case in first
> > patch.
> > 
> > --
> Ping Doug?

Sorry, I didn't see this before I wrote my last email.  You've already
captured Sean's acks, that's good.  You modified the first patch in a
way that negates the comment request I made, so that's fine.  But the
patches are still coming through mangled.  If you look at them in
patchworks, you can see telltale signs, such as seeing part of the
patch in the patchwork comments and then the full patch later on in the
patch section.  When I download those patches, they are mangled.  You
can *not* both send the patch inline and as an attachment.  The
prefered way to send patches, if your mailer is messing with your
submissions, is to use "git send-email" and let it send the patches
directly for you.

However, this time I have fixed the patches up and applied them, but
please don't send mangled patches like this in the future.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2017-01-13  4:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 12:15 [PATCHv2 0/4] IB cache port state, use it when resolve address Jinpu Wang
     [not found] ` <CAMGffE=-dN6jpJUHyNEHra1P=SLYiO47pMbMoKSNf6Njy=znKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-11 12:26   ` Jinpu Wang
     [not found]     ` <CAMGffE=xA9GMMWAKPMzAtWxHBSbBVft04LjB+fhc0mLRjmEXfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-13  4:02       ` Doug Ledford [this message]
     [not found]         ` <1484280123.123135.55.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-13  9:04           ` Jinpu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484280123.123135.55.camel@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=jinpu.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox