Re: [PATCH 1/3] IB/vmw_pvrdma: Defer activating device until vmxnet3 link is up

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

On Wed, 2017-01-18 at 11:42 -0700, Jason Gunthorpe wrote:
> On Wed, Jan 18, 2017 at 10:30:20AM -0800, Adit Ranadive wrote:
> 
> > 
> > We do register for netdev events so we get callbacks for the
> > link state. The problem happens when we call ib_register before the
> > vmxnet3
> > link is up. At this point the ib_core stack already has created the
> > QP1, etc.
> > Once the vmxnet3 link is up we would have to call
> > ib_unregister/ib_register
> > to recreate QP1. This might fail/stuck if the there is a user app
> > thats created
> > QPs and we're just waiting to free those resources.
> 
> Having to register/unregister on every link transition sounds like a
> horrible design, you should fix that :)

Indeed.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]