Re: [PATCH 1/3] IB/vmw_pvrdma: Defer activating device until vmxnet3 link is up

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2791 bytes --]

On Wed, 2017-01-18 at 16:31 -0800, Adit Ranadive wrote:
> On Wed, Jan 18, 2017 at 10:50:54PM +0000, Parav Pandit wrote:
> > 
> > Hi Adit,
> > 
> > > 
> > > -----Original Message-----
> > > From: Adit Ranadive [mailto:aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org]
> > > Sent: Wednesday, January 18, 2017 2:53 PM
> > > To: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> > > Cc: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; Leon Romanovsky
> > > <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; linux-rdma-u79uwXL29TaqPxH82wqD4g@public.gmane.org
> > > g; pv-
> > > drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org; Aditya Sarwade <asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
> > > Subject: Re: [PATCH 1/3] IB/vmw_pvrdma: Defer activating device
> > > until
> > > vmxnet3 link is up
> > > 
> > > On Wed, Jan 18, 2017 at 1:41:30PM -0700, Jason Gunthorpe wrote:
> > > > 
> > > > On Wed, Jan 18, 2017 at 12:30:07PM -0800, Adit Ranadive wrote:
> > > > 
> > > > > 
> > > > > In order to recover QP1 correctly after a link transition we
> > > > > had to
> > > > > go through a register/unregister since it is placed in error
> > > > > state when the
> > > port is down.
> > > > 
> > > > > 
> > > > > In this case can the MAD layer re-initialize QP1 if link
> > > > > transitions are
> > > performed?
> > > > 
> > > > 
> > > > Your driver needs to deal with this. Do whatever it takes to
> > > > recover
> > > > your QP1 without re-registring and do not bother the rest of
> > > > the
> > > > system with it.
> > > 
> > > Ok. We'll investigate internally on for a better recovery process
> > > for QP1.
> > 
> > By the time I reply, most others requested same.
> > Thanks for addressing it.
> 
> Hi Doug,
> 
> Please consider taking the other two patches in this series if
> possible
> for your next set of rc fixes.

If you want me to take these for the -rc cycle, then they need to be
presented appropriately.  This patch (1/3) is gone just because it was
the wrong solution (but it at least sounded like a fix).  Patch 2/3
starts its subject with "Cleanup unused...", that doesn't sound
remotely like a fix.  Patch 3/3 starts with "Don't hardcode...", which
also doesn't sound remotely like a fix.  If you want these in the -rc
cycle, then please repost the two other patches with suitable subjects
and commit logs that make it clear these are real fixes needed in an
-rc and not simple patches that should get applied in the for-next
area.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]