Re: [PATCH 1/2] IB/core: add the function ib_mtu_int_to_enum

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

On Wed, 2017-01-04 at 17:40 +0000, Hefty, Sean wrote:
> > 
> > You'll still be required to convert it to/from enum when
> > building/parsing CM messages, for example.
> > Also, why should it be an int if only specific values are allowed?
> 
> The enum values are IB specification specific, and are incomplete
> (note the lack of Ethernet mtu sizes).  Let the IB centric code deal
> with the conversion, and let the rest of the API be reasonable.  The
> IB CM uses the mtu value in the path record, which is fine.  Then
> maybe someday userspace can get access to the real mtu sizes as
> well...

Hi Sean,

While I don't disagree with your thoughts on the API change, the
original patch as it stands is a reasonable cleanup patch.  I'm not
going to condition one on the other as a result.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]