Re: [PATCH 1/1] IB/ipoib: Remove the unnecessary error check

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On Thu, 2017-01-19 at 10:35 +0200, Leon Romanovsky wrote:
> On Wed, Jan 18, 2017 at 11:16:06PM -0500, Zhu Yanjun wrote:
> > 
> > The function ipoib_mcast_start_thread/ipoib_ib_dev_up always return
> > zero.
> > As such, in the function ipoib_open, err_stop will never be
> > reached.
> > So remove this err_stop and change the return type of the function
> > ipoib_mcast_start_thread/ipoib_ib_dev_up to void.
> > 
> > Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/infiniband/ulp/ipoib/ipoib.h           | 4 ++--
> >  drivers/infiniband/ulp/ipoib/ipoib_ib.c        | 6 +++---
> >  drivers/infiniband/ulp/ipoib/ipoib_main.c      | 6 +-----
> >  drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 4 +---
> >  4 files changed, 7 insertions(+), 13 deletions(-)
> > 
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks, added to -next.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]