Re: [PATCH] i40iw: Set maj_err and min_err in i40iw_sc_cqp_create

[Doug Ledford <dledford@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

On Wed, 2017-01-18 at 21:54 +0200, Yuval Shaia wrote:
> On Wed, Jan 18, 2017 at 11:48:29AM -0600, Shiraz Saleem wrote:
> > 
> > Set maj_err and min_err in i40iw_sc_cqp_create so that it
> > returns correct values for all return cases. This also
> > addresses an uninitialized variable warning for maj_err and
> > min_err in i40iw_create_cqp.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Reported-by: Yuval Shaia <yuval.shaia@oracle.com>
> > Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> > ---
> >  drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > index 2c4b4d0..47a2529 100644
> > --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > @@ -315,6 +315,9 @@ static enum i40iw_status_code
> > i40iw_sc_cqp_create(struct i40iw_sc_cqp *cqp,
> >  	u32 cnt = 0, p1, p2, val = 0, err_code;
> >  	enum i40iw_status_code ret_code;
> >  
> > +	*maj_err = 0;
> > +	*min_err = 0;
> > +
> 
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

Thanks, applied to -next.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]