From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shan.hai-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 1/1] IB/ipoib: function interface change
Date: Tue, 24 Jan 2017 16:26:38 -0500 [thread overview]
Message-ID: <1485293198.43764.78.camel@redhat.com> (raw)
In-Reply-To: <20170112090143.GF20392-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Thu, 2017-01-12 at 11:01 +0200, Leon Romanovsky wrote:
> On Thu, Jan 12, 2017 at 02:39:01AM -0500, Zhu Yanjun wrote:
> >
> > The ipoib_ib_dev_down/ipoib_ib_dev_stop return zero unconditionally
> > and the callers never check the returned values,
> > change the return type to void and remove the redundant return
> > values.
> >
> > Reviewed-by: Shan Hai <shan.hai-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/infiniband/ulp/ipoib/ipoib.h | 4 ++--
> > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 8 ++------
> > 2 files changed, 4 insertions(+), 8 deletions(-)
> >
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-01-24 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 7:39 [PATCH 1/1] IB/ipoib: function interface change Zhu Yanjun
[not found] ` <1484206741-15218-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-01-12 7:59 ` Yuval Shaia
2017-01-12 9:01 ` Leon Romanovsky
[not found] ` <20170112090143.GF20392-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-24 21:26 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485293198.43764.78.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=shan.hai-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox