From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org"
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
"dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"avivh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<avivh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>a
Subject: Re: [PATCH] IB/core: Add inline function to validate port
Date: Wed, 25 Jan 2017 17:00:45 +0000 [thread overview]
Message-ID: <1485363630.2646.3.camel@sandisk.com> (raw)
In-Reply-To: <20170125165022.GQ6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Wed, 2017-01-25 at 18:50 +0200, Leon Romanovsky wrote:
> On Wed, Jan 25, 2017 at 06:41:37PM +0200, Yuval Shaia wrote:
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/infiniband/core/cache.c | 18 ++++++++----------
> > drivers/infiniband/core/cma.c | 6 ++----
> > drivers/infiniband/core/device.c | 4 ++--
> > drivers/infiniband/core/verbs.c | 3 +--
> > include/rdma/ib_verbs.h | 7 +++++++
> > 5 files changed, 20 insertions(+), 18 deletions(-)
>
> Nice change, however all places are pretended with "!".
> Can we change the name of function to something like
> "rdma_is_port_invalid"?
I prefer the current approach, namely with a positive function name.
Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-25 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 16:41 [PATCH] IB/core: Add inline function to validate port Yuval Shaia
[not found] ` <1485362497-18723-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-01-25 16:50 ` Leon Romanovsky
[not found] ` <20170125165022.GQ6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-25 17:00 ` Bart Van Assche [this message]
2017-01-26 8:15 ` Yuval Shaia
[not found] ` <20170126081534.GC3939-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2017-01-26 12:59 ` Leon Romanovsky
2017-01-27 19:34 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485363630.2646.3.camel@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=avivh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
--cc=talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox