From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"sean.hefty@intel.com" <sean.hefty@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] IB/cma: Fix reversed test
Date: Fri, 27 Jan 2017 21:31:55 +0000 [thread overview]
Message-ID: <1485552696.13218.0.camel@sandisk.com> (raw)
In-Reply-To: <20170127131535.19918-1-christophe.jaillet@wanadoo.fr>
On Fri, 2017-01-27 at 14:15 +0100, Christophe JAILLET wrote:
> This test looks reverted.
> We should log an error message only if 'ib_attach_mcast()' fails.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/core/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index cfefb941d729..175f62e5841e 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -3838,7 +3838,7 @@ static int cma_ib_mc_handler(int status, struct ib_sa_multicast *multicast)
> if (!status && id_priv->id.qp) {
> status = ib_attach_mcast(id_priv->id.qp, &multicast->rec.mgid,
> be16_to_cpu(multicast->rec.mlid));
> - if (!status)
> + if (status)
> pr_debug_ratelimited("RDMA CM: MULTICAST_ERROR: failed to attach QP. status %d\n",
> status);
> }
Hello Christophe,
Do you think this patch needs "Fixes:" and "Cc: stable" tags?
Thanks,
Bart.
next prev parent reply other threads:[~2017-01-27 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 13:15 [PATCH] IB/cma: Fix reversed test Christophe JAILLET
2017-01-27 19:24 ` Doug Ledford
2017-01-27 21:31 ` Bart Van Assche [this message]
[not found] ` <1485552696.13218.0.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-28 0:05 ` Doug Ledford
2017-01-28 6:59 ` Dan Carpenter
2017-01-28 12:47 ` Majd Dibbiny
2017-01-28 13:01 ` Majd Dibbiny
2017-02-03 18:34 ` Doug Ledford
[not found] ` <2fde1e87-a345-4697-e205-051a3973e624-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-06 9:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485552696.13218.0.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox