From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Matan Barak (External)"
<matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bodong Wang <bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH rdma-rc v1] RDMA: Remove kernel private defines and reference to header from UAPI
Date: Wed, 08 Feb 2017 12:42:49 -0500 [thread overview]
Message-ID: <1486575769.86943.17.camel@redhat.com> (raw)
In-Reply-To: <20170208172544.GF6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Wed, 2017-02-08 at 19:25 +0200, Leon Romanovsky wrote:
> > I tried to write this earlier, but for some reason my mailer didn't
> really
> > send it.
> > IMHO, since these enum values are actually passed between user-
> space and
> > kernel (attr_mask), it's acceptable to expose all enum values.
> > Otherwise, user-space should define all these symbols by by itself
> (as done
> > today), so why bother introduce only this explicit symbol?
>
> Mainly because it is -rc7 fix and it is MUST be applied as soon
> as possible, currently IB stack is broken.
Indeed, which is why I took the V1 of the patch. We can fix it up
nicer in -next if people prefer.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-02-08 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 15:04 [PATCH rdma-rc v1] RDMA: Remove kernel private defines and reference to header from UAPI Leon Romanovsky
[not found] ` <20170208150409.29537-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-08 15:15 ` Matan Barak (External)
[not found] ` <8c2f6c58-f622-95cf-e146-ed7a5747fd9a-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-02-08 17:25 ` Leon Romanovsky
[not found] ` <20170208172544.GF6005-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-02-08 17:42 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486575769.86943.17.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox