From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 0/8] IB/srp bug fixes Date: Tue, 14 Feb 2017 17:18:11 +0000 Message-ID: <1487092678.2466.6.camel@sandisk.com> References: <20170210235611.3243-1-bart.vanassche@sandisk.com> <20170210235611.3243-9-bart.vanassche@sandisk.com> <20170212171928.GF14015@mtr-leonro.local> <1041506550.30101266.1486922573298.JavaMail.zimbra@redhat.com> <1051975432.30101289.1486922792858.JavaMail.zimbra@redhat.com> <1465409120.30916025.1487041332560.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1465409120.30916025.1487041332560.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: <01E2318C8D70E7478CA3887E5B11DBFF-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "hch-jcswGhMUV9g@public.gmane.org" , "maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Mon, 2017-02-13 at 22:02 -0500, Laurence Oberman wrote: > The following 7 of 8 patches were applied to Linus's latest tree. > > However this required first reverting > > commit ad8e66b4a80182174f73487ed25fd2140cf43361 > Author: Israel Rukshin > Date: Wed Dec 28 12:48:28 2016 +0200 > > See my other email regarding why the above needed to be reverted. > > All tests passed in my mlx5 EDR-100 test bed for the ib-srp/mlx5 tests. > > 4.10.0-rc8.bart+ > > The revert of the above meant I did not apply and test patch 6 of the series > IB/srp: Use the IB_DEVICE_SG_GAPS_REG HCA feature if supported > > IB/srp: Avoid that duplicate responses trigger a kernel bug > IB/srp: Fix race conditions related to task management > IB/srp: Document locking conventions > IB/srp: Make a diagnostic message more informative > IB/srp: Improve an error path > *** Not applied and not tested IB/srp: Use the IB_DEVICE_SG_GAPS_REG HCA feature if supported > IB/core: Add support for draining IB_POLL_DIRECT completion queues > IB/srp: Drain the send queue before destroying a QP > > For the series except patch 6 > > Tested-by: Laurence Oberman Hello Laurence, Thank you for the testing. However, reverting commit ad8e66b4a801 without making any further changes is not acceptable because it would reintroduce the SG-list mapping problem addressed by that patch. Can you test the srp-initiator-for-next branch from my github repository against mlx5 (commit 8dca762deab6)? It passes my tests against mlx4. The patches on that branch are: Bart Van Assche (8):       IB/SRP: Avoid using IB_MR_TYPE_SG_GAPS       IB/srp: Avoid that duplicate responses trigger a kernel bug       IB/srp: Fix race conditions related to task management       IB/srp: Document locking conventions       IB/srp: Make a diagnostic message more informative       IB/srp: Improve an error path       IB/core: Add support for draining IB_POLL_DIRECT completion queues       IB/srp: Drain the send queue before destroying a QP Thanks, Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html