From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v2 1/8] IB/SRP: Avoid using IB_MR_TYPE_SG_GAPS Date: Wed, 15 Feb 2017 00:22:20 +0000 Message-ID: <1487118126.2466.31.camel@sandisk.com> References: <20170214185636.29250-1-bart.vanassche@sandisk.com> <20170214185636.29250-2-bart.vanassche@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20170214185636.29250-2-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Content-Language: en-US Content-ID: <735EAB98627AC64999DB1DF7D53A9D95-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org" , "maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, 2017-02-14 at 10:56 -0800, Bart Van Assche wrote: > @@ -2666,7 +2661,7 @@ static int srp_slave_alloc(struct scsi_device *sdev) > struct srp_device *srp_dev = target->srp_host->srp_dev; > struct ib_device *ibdev = srp_dev->dev; > > - if (!(ibdev->attrs.device_cap_flags & IB_DEVICE_SG_GAPS_REG)) > + if (true) > blk_queue_virt_boundary(sdev->request_queue, > ~srp_dev->mr_page_mask); Hello Doug, This patch introduces a new warning when building with W=1, namely that variable ibdev is not used. The build bot figured this out. Do you want me to address this? Thanks, Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html