From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"mnghuan@gmail.com" <mnghuan@gmail.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"sean.hefty@intel.com" <sean.hefty@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] ib_srp: Let compiler ignore the useless debug code
Date: Fri, 24 Feb 2017 16:16:31 +0000 [thread overview]
Message-ID: <1487952911.2575.1.camel@sandisk.com> (raw)
In-Reply-To: <20170224084451.42117-1-mnghuan@gmail.com>
On Fri, 2017-02-24 at 16:44 +0800, Minfei Huang wrote:
> "if (0)" is used to make this block of debug code not be executed. There
> is a more elegant way to let compiler ignore this code, using
> "#if 0 .. #endif" instead.
>
> Although it may be optimised by some compilers with specified parameter,
> just for readable.
#if 0 / #endif prevents the compiler from checking the syntax of the code.
Such code tends to grow syntax errors. So I'm not sure this patch is an
improvement.
Bart.
next prev parent reply other threads:[~2017-02-24 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 8:44 [PATCH] ib_srp: Let compiler ignore the useless debug code Minfei Huang
2017-02-24 16:16 ` Bart Van Assche [this message]
[not found] ` <1487952911.2575.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-05 8:22 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487952911.2575.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mnghuan@gmail.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox