From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "parav@mellanox.com" <parav@mellanox.com>,
"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"sebott@linux.vnet.ibm.com" <sebott@linux.vnet.ibm.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Subject: Re: [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev
Date: Tue, 7 Mar 2017 02:44:28 +0000 [thread overview]
Message-ID: <1488854653.2997.1.camel@sandisk.com> (raw)
In-Reply-To: <VI1PR0502MB3008D3B38ED2F3694E100E5ED12F0@VI1PR0502MB3008.eurprd05.prod.outlook.com>
On Tue, 2017-03-07 at 02:41 +0000, Parav Pandit wrote:
> Compilation would break when CONFIG_PCI is not defined for some embedded platforms.
> More than that, including specific pci_dev structure pointer in generic structure such as device just doesn't sound right.
> I tested equivalent patch that you sent, but I don't think this is right direction to fix this bug.
You are welcome to voice your opinion. But unless anyone proposes a better
alternative I propose to proceed with this approach.
Bart.
next prev parent reply other threads:[~2017-03-07 2:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 0:35 [PATCH 0/2] IB/core fixes for kernel v4.11-rc Bart Van Assche
[not found] ` <20170307003549.3872-1-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-07 0:35 ` [PATCH 1/2] device: Stop requiring that struct device is embedded in struct pci_dev Bart Van Assche
[not found] ` <20170307003549.3872-2-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-07 2:41 ` Parav Pandit
2017-03-07 2:44 ` Bart Van Assche [this message]
[not found] ` <1488854653.2997.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-07 4:50 ` gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
2017-03-07 3:21 ` Parav Pandit
2017-03-07 4:52 ` Greg Kroah-Hartman
2017-03-07 16:54 ` Bart Van Assche
[not found] ` <1488905685.2739.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-07 17:14 ` gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
2017-03-07 18:27 ` Parav Pandit
[not found] ` <20170307045236.GC3913-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-03-07 5:08 ` Parav Pandit
[not found] ` <VI1PR0502MB3008BEC2FB8747DDA40A10FCD12F0-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-03-07 5:13 ` Bart Van Assche
[not found] ` <1488863593.2997.3.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-07 5:20 ` Parav Pandit
2017-03-08 1:52 ` Benjamin Herrenschmidt
2017-03-07 0:35 ` [PATCH 2/2] IB/core: Restore I/O MMU, s390 and powerpc support Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488854653.2997.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=dledford@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=parav@mellanox.com \
--cc=sebott@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox