From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] IB/cq: Don't process more than the given budget Date: Wed, 8 Mar 2017 22:09:08 +0000 Message-ID: <1489010916.2813.4.camel@sandisk.com> References: <1489003801-4410-1-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1489003801-4410-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Content-Language: en-US Content-ID: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org" Cc: "hch-jcswGhMUV9g@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Wed, 2017-03-08 at 22:10 +0200, Sagi Grimberg wrote: > The caller might not want this overhead. >=20 > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/core/cq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/infiniband/core/cq.c b/drivers/infiniband/core/cq.c > index 2746d2eb3d52..c98d15ce2880 100644 > --- a/drivers/infiniband/core/cq.c > +++ b/drivers/infiniband/core/cq.c > @@ -29,7 +29,8 @@ static int __ib_process_cq(struct ib_cq *cq, int budget= ) > { > int i, n, completed =3D 0; > =20 > - while ((n =3D ib_poll_cq(cq, IB_POLL_BATCH, cq->wc)) > 0) { > + while ((n =3D ib_poll_cq(cq, min(IB_POLL_BATCH, budget - completed), > + cq->wc)) > 0) { > for (i =3D 0; i < n; i++) { > struct ib_wc *wc =3D &cq->wc[i]; > =20 This breaks the SRP initiator driver since that driver can pass -1 as budge= t. Bart.= -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html