public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "vlad-NIZqynvkaCU43zv7NVfAiQ@public.gmane.org"
	<vlad-NIZqynvkaCU43zv7NVfAiQ@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] infiniband/uverbs: Fix integer overflows
Date: Fri, 24 Mar 2017 20:02:03 +0000	[thread overview]
Message-ID: <1490385702.3312.18.camel@sandisk.com> (raw)
In-Reply-To: <1490385317-35641-1-git-send-email-vlad-NIZqynvkaCU43zv7NVfAiQ@public.gmane.org>

On Fri, 2017-03-24 at 15:55 -0400, Vlad Tsyrklevich wrote:
> The 'num_sge' variable is verfied to be smaller than the 'sge_count'
> variable; however, since both are user-controlled it's possible to cause
> an integer overflow for the kmalloc multiply on 32-bit platforms
> (num_sge and sge_count are both defined u32). By crafting an input that
> causes a smaller-than-expected allocation it's possible to write
> controlled data out-of-bounds.

Hello Vlad,

Do you think that an RDMA driver exists that supports a max_sge value that
is large enough to cause this multiplication to overflow?

Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-03-24 20:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 19:55 [PATCH v2] infiniband/uverbs: Fix integer overflows Vlad Tsyrklevich
     [not found] ` <1490385317-35641-1-git-send-email-vlad-NIZqynvkaCU43zv7NVfAiQ@public.gmane.org>
2017-03-24 20:02   ` Bart Van Assche [this message]
     [not found]     ` <1490385702.3312.18.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-24 20:45       ` Vlad Tsyrklevich
     [not found]         ` <CAH0z3hM8a4Hra3+gvz5HeFBcmkqmP0KhFQsFQh30SActK+p7mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-25 19:18           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490385702.3312.18.camel@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vlad-NIZqynvkaCU43zv7NVfAiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox