From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] IB/core: Protect against self-requeue of a cq work item Date: Fri, 24 Mar 2017 16:41:54 -0400 Message-ID: <1490388114.2404.24.camel@redhat.com> References: <1489003252-1893-1-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1489003252-1893-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Christoph Hellwig , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, 2017-03-08 at 22:00 +0200, Sagi Grimberg wrote: > We need to make sure that the cq work item does not > run when we are destroying the cq. Unlike flush_work, > cancel_work_sync protects against self-requeue of the > work item (which we can do in ib_cq_poll_work). > > Signed-off-by: Sagi Grimberg Hi Sagi, I didn't know if this was a theoretical or you actually hit this in practice, so I pulled it for -rc in case it was actually being hit in the wild.  Thanks. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html