From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] IB/rxe: double free on error Date: Fri, 24 Mar 2017 21:48:49 -0400 Message-ID: <1490406529.2404.35.camel@redhat.com> References: <20170308052152.GA31503@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170308052152.GA31503@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter , Moni Shoua Cc: Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On Wed, 2017-03-08 at 08:21 +0300, Dan Carpenter wrote: > "goto err;" has it's own kfree_skb() call so it's a double free.  We > only need to free on the "goto exit;" path. > > Fixes: 8700e3e7c485 ("Soft RoCE driver") > Signed-off-by: Dan Carpenter Thanks, applied to -rc. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD