public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org"
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: rdma-core.spec and -DIN_PLACE
Date: Mon, 27 Mar 2017 20:50:01 +0000	[thread overview]
Message-ID: <1490647788.7897.5.camel@sandisk.com> (raw)

Hello Jason,

When I build an RPM using the top-level rdma-core.spec file I need the following
patch to ensure that the verbs library looks into /etc/libibverbs.d instead of a
path in the build directory:

diff --git a/rdma-core.spec b/rdma-core.spec
index 6a280fe1..f2419e82 100644
--- a/rdma-core.spec
+++ b/rdma-core.spec
@@ -34,7 +34,7 @@ BuildRequires: ninja,make
 # Tumbleweed's cmake RPM macro adds -Wl,--no-undefined to the module flags
 # which is totally inappropriate and breaks building 'ENABLE_EXPORTS' style
 # module libraries (eg ibacmp).
-%define CMAKE_FLAGS -DCMAKE_MODULE_LINKER_FLAGS=""
+%define CMAKE_FLAGS -DCMAKE_MODULE_LINKER_FLAGS="" -DIN_PLACE=0
 %else
 %if 0%{?fedora} >= 23
 # Ninja was introduced in FC23

Do you think this is an issue with the spec file or with one of the CMake files?

The script I use to build an RPM is as follows:

#!/bin/sh

name=rdma-core
version=$(sed -n 's/^Version:[[:blank:]]*//p' rdma-core.spec)
rpmtopdir=$PWD/rpmbuilddir

rm -rf ${rpmtopdir} &&
    mkdir -p ${rpmtopdir}/{BUILD,RPMS,SOURCES,SPECS,SRPMS} &&
    git archive --prefix rdma-core-${version}/ --output ${rpmtopdir}/SOURCES/${name}-${version}.tgz HEAD &&
    rpmbuild --define="%_topdir ${rpmtopdir}" -ba ${name}.spec

Thanks,

Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2017-03-27 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 20:50 Bart Van Assche [this message]
     [not found] ` <1490647788.7897.5.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-03-27 22:44   ` rdma-core.spec and -DIN_PLACE Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490647788.7897.5.camel@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox