linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	linux-rdma@vger.kernel.org,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Sean Hefty <sean.hefty@intel.com>, Steve Wise <swise@chelsio.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations
Date: Wed, 05 Apr 2017 14:16:14 -0400	[thread overview]
Message-ID: <1491416174.2923.3.camel@redhat.com> (raw)
In-Reply-To: <0aff92fa-2891-333a-2e1e-ca309db2ec72@users.sourceforge.net>

On Wed, 2017-02-08 at 22:10 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 8 Feb 2017 22:00:10 +0100
> 
> Several update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (14):
>   Use kcalloc() in cxio_create_qp()
>   Rename jump labels in cxio_create_qp()
>   Use kcalloc() in two functions
>   Use common error handling code in recover_queues()
>   Return an error code only as a constant in ep_open()
>   Return an error code only as a constant in stag_open()
>   Adjust three checks for null pointers
>   Adjust construction of two error messages in recover_lost_dbs()
>   Use common error handling code in recover_lost_dbs()
>   Use kmalloc_array() in c4iw_id_table_alloc()
>   Use kcalloc() in create_qp()
>   Delete an unnecessary variable initialisation in create_qp()
>   Rename jump labels in c4iw_create_qp()
>   Rename jump labels in rdma_init()
> 
>  drivers/infiniband/hw/cxgb3/cxio_hal.c | 20 ++++----
>  drivers/infiniband/hw/cxgb4/device.c   | 83 +++++++++++++++---------
> ----------
>  drivers/infiniband/hw/cxgb4/id_table.c |  5 +-
>  drivers/infiniband/hw/cxgb4/qp.c       | 48 ++++++++++----------
>  4 files changed, 75 insertions(+), 81 deletions(-)

I didn't see enough value in this series to bother picking it up.
 Steve, if there are any patches out of this series you actually want,
please collect them and forward them on to me.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

  parent reply	other threads:[~2017-04-05 18:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 21:10 [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations SF Markus Elfring
2017-02-08 21:11 ` [PATCH 01/14] RDMA/cxgb3: Use kcalloc() in cxio_create_qp() SF Markus Elfring
2017-02-08 21:12 ` [PATCH 02/14] RDMA/cxgb3: Rename jump labels " SF Markus Elfring
2017-02-08 21:35   ` Andy Shevchenko
2017-02-08 21:14 ` [PATCH 04/14] RDMA/cxgb4: Use common error handling code in recover_queues() SF Markus Elfring
2017-02-09  9:30   ` Johannes Thumshirn
     [not found] ` <0aff92fa-2891-333a-2e1e-ca309db2ec72-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-02-08 21:13   ` [PATCH 03/14] RDMA/cxgb4: Use kcalloc() in two functions SF Markus Elfring
2017-02-08 21:15   ` [PATCH 05/14] RDMA/cxgb4: Return an error code only as a constant in ep_open() SF Markus Elfring
2017-02-08 21:18   ` [PATCH 08/14] RDMA/cxgb4: Adjust construction of two error messages in recover_lost_dbs() SF Markus Elfring
2017-02-08 21:22   ` [PATCH 12/14] RDMA/cxgb4: Delete an unnecessary variable initialisation in create_qp() SF Markus Elfring
     [not found]     ` <b319a50e-9e2a-61c0-5707-b4549b077d6a-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-02-09  9:02       ` Leon Romanovsky
2017-02-08 21:23   ` [PATCH 13/14] RDMA/cxgb4: Rename jump labels in c4iw_create_qp() SF Markus Elfring
2017-02-08 21:24   ` [PATCH 14/14] RDMA/cxgb4: Rename jump labels in rdma_init() SF Markus Elfring
2017-02-08 21:16 ` [PATCH 06/14] RDMA/cxgb4: Return an error code only as a constant in stag_open() SF Markus Elfring
2017-02-08 21:17 ` [PATCH 07/14] RDMA/cxgb4: Adjust three checks for null pointers SF Markus Elfring
2017-02-08 21:19 ` [PATCH 09/14] RDMA/cxgb4: Use common error handling code in recover_lost_dbs() SF Markus Elfring
2017-02-09 18:57   ` Leon Romanovsky
2017-02-08 21:20 ` [PATCH 10/14] RDMA/cxgb4: Use kmalloc_array() in c4iw_id_table_alloc() SF Markus Elfring
2017-02-08 21:21 ` [PATCH 11/14] RDMA/cxgb4: Use kcalloc() in create_qp() SF Markus Elfring
2017-04-05 18:16 ` Doug Ledford [this message]
     [not found]   ` <1491416174.2923.3.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-04-09  6:30     ` [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491416174.2923.3.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=elfring@users.sourceforge.net \
    --cc=hal.rosenstock@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).