* [PATCH rdma-core 2/3] srp_daemon/srp_daemon.c: Eliminate some unneeded code in get_shared_pkeys
@ 2017-04-13 14:48 Hal Rosenstock
[not found] ` <a14febfc-a190-6ca8-5dca-dec58f5a3bce-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Hal Rosenstock @ 2017-04-13 14:48 UTC (permalink / raw)
To: Doug Ledford
Cc: Honggang LI, Bart Van Assche,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
PathRecords are obtained using SubAdmGet and not SubAdmGetTable
so RMPP is not involved. Eliminate unneeded initialization of MAD
RMPP fields.
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
srp_daemon/srp_daemon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
index 9fb2ecc..59a6137 100644
--- a/srp_daemon/srp_daemon.c
+++ b/srp_daemon/srp_daemon.c
@@ -1134,8 +1134,6 @@ static int get_shared_pkeys(struct resources *res,
/* Mark components: DLID, SLID, PKEY */
out_sa_mad->comp_mask = htobe64(1 << 4 | 1 << 5 | 1 << 13);
- out_sa_mad->rmpp_hdr.rmpp_version = UMAD_RMPP_VERSION;
- out_sa_mad->rmpp_hdr.rmpp_type = 1;
path_rec = (struct ib_path_rec *)out_sa_mad->data;
path_rec->slid = htobe16(local_port_lid);
path_rec->dlid = htobe16(dest_port_lid);
--
1.8.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH rdma-core 2/3] srp_daemon/srp_daemon.c: Eliminate some unneeded code in get_shared_pkeys
[not found] ` <a14febfc-a190-6ca8-5dca-dec58f5a3bce-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2017-04-13 15:25 ` Bart Van Assche
2017-04-14 0:34 ` Honggang LI
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2017-04-13 15:25 UTC (permalink / raw)
To: hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Thu, 2017-04-13 at 10:48 -0400, Hal Rosenstock wrote:
> PathRecords are obtained using SubAdmGet and not SubAdmGetTable
> so RMPP is not involved. Eliminate unneeded initialization of MAD
> RMPP fields.
Reviewed-by: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH rdma-core 2/3] srp_daemon/srp_daemon.c: Eliminate some unneeded code in get_shared_pkeys
[not found] ` <a14febfc-a190-6ca8-5dca-dec58f5a3bce-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-04-13 15:25 ` Bart Van Assche
@ 2017-04-14 0:34 ` Honggang LI
1 sibling, 0 replies; 3+ messages in thread
From: Honggang LI @ 2017-04-14 0:34 UTC (permalink / raw)
To: Hal Rosenstock
Cc: Doug Ledford, Bart Van Assche,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Thu, Apr 13, 2017 at 10:48:25AM -0400, Hal Rosenstock wrote:
>
> PathRecords are obtained using SubAdmGet and not SubAdmGetTable
> so RMPP is not involved. Eliminate unneeded initialization of MAD
> RMPP fields.
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> srp_daemon/srp_daemon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
> index 9fb2ecc..59a6137 100644
> --- a/srp_daemon/srp_daemon.c
> +++ b/srp_daemon/srp_daemon.c
> @@ -1134,8 +1134,6 @@ static int get_shared_pkeys(struct resources *res,
>
> /* Mark components: DLID, SLID, PKEY */
> out_sa_mad->comp_mask = htobe64(1 << 4 | 1 << 5 | 1 << 13);
> - out_sa_mad->rmpp_hdr.rmpp_version = UMAD_RMPP_VERSION;
> - out_sa_mad->rmpp_hdr.rmpp_type = 1;
> path_rec = (struct ib_path_rec *)out_sa_mad->data;
> path_rec->slid = htobe16(local_port_lid);
> path_rec->dlid = htobe16(dest_port_lid);
> --
> 1.8.2.3
>
Reviewed-by: Honggang Li <honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-14 0:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-13 14:48 [PATCH rdma-core 2/3] srp_daemon/srp_daemon.c: Eliminate some unneeded code in get_shared_pkeys Hal Rosenstock
[not found] ` <a14febfc-a190-6ca8-5dca-dec58f5a3bce-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-04-13 15:25 ` Bart Van Assche
2017-04-14 0:34 ` Honggang LI
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox