From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH rdma-next 1/2] IB/ipoib: Update broadcast object if PKey value was changed in index 0 Date: Mon, 24 Apr 2017 12:03:19 -0400 Message-ID: <1493049799.3041.30.camel@redhat.com> References: <20170319091855.8419-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170319091855.8419-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Feras Daoud , Erez Shitrit List-Id: linux-rdma@vger.kernel.org On Sun, 2017-03-19 at 11:18 +0200, Leon Romanovsky wrote: > From: Feras Daoud > > Update the broadcast address in the priv->broadcast object when the > Pkey value changes in index 0, otherwise the multicast GID value will > keep the previous value of the PKey, and will not be updated. > This leads to interface state down because the interface will keep > the > old PKey value. > > For example, in SR-IOV environment, if the PF changes the value of > PKey > index 0 for one of the VFs, then the VF receives PKey change event > that > triggers heavy flush. This flush calls update_parent_pkey that update > the > broadcast object and its relevant members. If in this case the > multicast > GID will not be updated, the interface state will be down. > > Fixes: c2904141696e ("IPoIB: Fix pkey change flow for virtualization > environments") > Signed-off-by: Feras Daoud > Signed-off-by: Erez Shitrit > Reviewed-by: Alex Vesker > Signed-off-by: Leon Romanovsky Thanks, applied. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html