From: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org
Cc: Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Subject: [rdma-core 2/4] libqedr: fail post_send on WR overflow
Date: Thu, 27 Apr 2017 09:11:06 +0300 [thread overview]
Message-ID: <1493273468-23774-3-git-send-email-Ram.Amrani@cavium.com> (raw)
In-Reply-To: <1493273468-23774-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Post send will fail if it is full, thus preventing an overflow.
Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
---
providers/qedr/qelr_verbs.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/providers/qedr/qelr_verbs.c b/providers/qedr/qelr_verbs.c
index 8d94a12..7419540 100644
--- a/providers/qedr/qelr_verbs.c
+++ b/providers/qedr/qelr_verbs.c
@@ -70,6 +70,11 @@ static void qelr_inc_sw_prod_u16(struct qelr_qp_hwq_info *info)
info->prod = (info->prod + 1) % info->max_wr;
}
+static inline int qelr_wq_is_full(struct qelr_qp_hwq_info *info)
+{
+ return (((info->prod + 1) % info->max_wr) == info->cons);
+}
+
int qelr_query_device(struct ibv_context *context,
struct ibv_device_attr *attr)
{
@@ -1144,6 +1149,14 @@ static inline int qelr_can_post_send(struct qelr_devctx *cxt,
return -EINVAL;
}
+ /* WR overflow */
+ if (qelr_wq_is_full(&qp->sq)) {
+ DP_ERR(cxt->dbg_fp,
+ "error: WQ is full. Post send on QP %p failed (this error appears only once)\n",
+ qp);
+ return -ENOMEM;
+ }
+
/* WQE overflow */
if (qelr_chain_get_elem_left_u32(&qp->sq.chain) <
QELR_MAX_SQ_WQE_SIZE) {
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-27 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 6:11 [rdma-core 0/4] libqedr: cumulative updates and fixes Ram Amrani
[not found] ` <1493273468-23774-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-04-27 6:11 ` [rdma-core 1/4] libqedr: remove obsolete device IDs Ram Amrani
2017-04-27 6:11 ` Ram Amrani [this message]
2017-04-27 6:11 ` [rdma-core 3/4] libqedr: fix comments and alignment in verbs file Ram Amrani
2017-04-27 6:11 ` [rdma-core 4/4] libqedr: prevent EDPM loopback Ram Amrani
2017-04-27 8:44 ` [rdma-core 0/4] libqedr: cumulative updates and fixes Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493273468-23774-3-git-send-email-Ram.Amrani@cavium.com \
--to=ram.amrani-ygcgfspz5w/qt0dzr+alfa@public.gmane.org \
--cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox