linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] i40iw: MPA connection establishment flow fixes
@ 2017-05-05 17:05 Henry Orosco
       [not found] ` <20170505170517.10372-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Henry Orosco @ 2017-05-05 17:05 UTC (permalink / raw)
  To: dledford-H+wXaHxf7aLQT0dZR+AlfA
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Henry Orosco

The following patch series contains fixes related to
the MPA connection establishment flow.

Tatyana Nikolova (2):
  i40iw: Don't set 0-length FULPDU RTR indication control flag
  i40iw: ACK MPA Reject frame

 drivers/infiniband/hw/i40iw/i40iw_cm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.8.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] i40iw: Don't set 0-length FULPDU RTR indication control flag
       [not found] ` <20170505170517.10372-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2017-05-05 17:05   ` Henry Orosco
  2017-05-05 17:05   ` [PATCH 2/2] i40iw: ACK MPA Reject frame Henry Orosco
  2017-06-01 22:11   ` [PATCH 0/2] i40iw: MPA connection establishment flow fixes Doug Ledford
  2 siblings, 0 replies; 4+ messages in thread
From: Henry Orosco @ 2017-05-05 17:05 UTC (permalink / raw)
  To: dledford-H+wXaHxf7aLQT0dZR+AlfA
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Tatyana Nikolova,
	Henry Orosco

From: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Don't set control flag for 0-length FULPDU (Send)
RTR indication in the enhanced MPA Request/Reply
frames, because it isn't supported.

Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Henry Orosco <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/i40iw/i40iw_cm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index 8563769..36975a1 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -790,7 +790,6 @@ static void i40iw_build_mpa_v2(struct i40iw_cm_node *cm_node,
 	}
 
 	ctrl_ird |= IETF_PEER_TO_PEER;
-	ctrl_ird |= IETF_FLPDU_ZERO_LEN;
 
 	switch (mpa_key) {
 	case MPA_KEY_REQUEST:
-- 
2.8.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] i40iw: ACK MPA Reject frame
       [not found] ` <20170505170517.10372-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
  2017-05-05 17:05   ` [PATCH 1/2] i40iw: Don't set 0-length FULPDU RTR indication control flag Henry Orosco
@ 2017-05-05 17:05   ` Henry Orosco
  2017-06-01 22:11   ` [PATCH 0/2] i40iw: MPA connection establishment flow fixes Doug Ledford
  2 siblings, 0 replies; 4+ messages in thread
From: Henry Orosco @ 2017-05-05 17:05 UTC (permalink / raw)
  To: dledford-H+wXaHxf7aLQT0dZR+AlfA
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Tatyana Nikolova,
	Henry Orosco

From: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Explicitly ACK the MPA Reject frame so the peer does
not retransmit the frame.

Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Henry Orosco <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index 36975a1..52849f5 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -2427,8 +2427,8 @@ static void i40iw_handle_rcv_mpa(struct i40iw_cm_node *cm_node,
 		} else {
 			type = I40IW_CM_EVENT_CONNECTED;
 			cm_node->state = I40IW_CM_STATE_OFFLOADED;
-			i40iw_send_ack(cm_node);
 		}
+		i40iw_send_ack(cm_node);
 		break;
 	default:
 		pr_err("%s wrong cm_node state =%d\n", __func__, cm_node->state);
-- 
2.8.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] i40iw: MPA connection establishment flow fixes
       [not found] ` <20170505170517.10372-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
  2017-05-05 17:05   ` [PATCH 1/2] i40iw: Don't set 0-length FULPDU RTR indication control flag Henry Orosco
  2017-05-05 17:05   ` [PATCH 2/2] i40iw: ACK MPA Reject frame Henry Orosco
@ 2017-06-01 22:11   ` Doug Ledford
  2 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2017-06-01 22:11 UTC (permalink / raw)
  To: Henry Orosco
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

On Fri, 2017-05-05 at 12:05 -0500, Henry Orosco wrote:
> The following patch series contains fixes related to
> the MPA connection establishment flow.
> 
> Tatyana Nikolova (2):
>   i40iw: Don't set 0-length FULPDU RTR indication control flag
>   i40iw: ACK MPA Reject frame
> 
>  drivers/infiniband/hw/i40iw/i40iw_cm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-01 22:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-05 17:05 [PATCH 0/2] i40iw: MPA connection establishment flow fixes Henry Orosco
     [not found] ` <20170505170517.10372-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-05 17:05   ` [PATCH 1/2] i40iw: Don't set 0-length FULPDU RTR indication control flag Henry Orosco
2017-05-05 17:05   ` [PATCH 2/2] i40iw: ACK MPA Reject frame Henry Orosco
2017-06-01 22:11   ` [PATCH 0/2] i40iw: MPA connection establishment flow fixes Doug Ledford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).