From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH rdma-rc v1] IB/uverbs: Declare local function to be static and add brackets to sizeof Date: Thu, 01 Jun 2017 19:03:40 -0400 Message-ID: <1496358220.7171.78.camel@redhat.com> References: <20170518044033.8637-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170518044033.8637-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Thu, 2017-05-18 at 07:40 +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Commit 57520751445b ("IB/SA: Add OPA path record type") introduced > new local function __ib_copy_path_rec_to_user, but didn't limit its > scope. This produces the following sparse warning: > >         drivers/infiniband/core/uverbs_marshall.c:99:6: warning: >         symbol '__ib_copy_path_rec_to_user' was not declared. Should > it be >         static? > > In addition, it used sizeof ... notations instead of sizeof(...), > which > is correct in C, but a little bit misleading. Let's change it too. > > Fixes: 57520751445b ("IB/SA: Add OPA path record type") > Reviewed-by: Yuval Shaia > Signed-off-by: Leon Romanovsky Thanks, applied. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html