From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] IB/addr: Fix setting source address in addr6_resolve() Date: Wed, 07 Jun 2017 20:18:59 -0400 Message-ID: <1496881139.7171.185.camel@redhat.com> References: <20170606162200.24629-1-roland@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170606162200.24629-1-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier , Paolo Abeni Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, 2017-06-06 at 09:22 -0700, Roland Dreier wrote: > From: Roland Dreier > > Commit eea40b8f624f ("infiniband: call ipv6 route lookup via the stub > interface") introduced a regression in address resolution when > connecting > to IPv6 destination addresses.  The old code called > ip6_route_output(), > while the new code calls ipv6_stub->ipv6_dst_lookup().  The two are > almost > the same, except that ipv6_dst_lookup() also calls > ip6_route_get_saddr() > if the source address is in6addr_any. > > This means that the test of ipv6_addr_any(&fl6.saddr) now never > succeeds, > and so we never copy the source address out.  This ends up causing > rdma_resolve_addr() to fail, because without a resolved source > address, > cma_acquire_dev() will fail to find an RDMA device to use.  For me, > this > causes connecting to an NVMe over Fabrics target via RoCE / IPv6 to > fail. > > Fix this by copying out fl6.saddr if ipv6_addr_any() is true for the > original > source address passed into addr6_resolve().  We can drop our call to > ipv6_dev_get_saddr() because ipv6_dst_lookup() already does that > work. > > Fixes: eea40b8f624 ("infiniband: call ipv6 route lookup via the stub > interface") > Cc: # 3.12+ > Signed-off-by: Roland Dreier Thanks Roland, applied. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html