From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH resend] rxe: fix broken receive queue draining Date: Tue, 11 Jul 2017 22:42:38 +0000 Message-ID: <1499812957.2586.47.camel@wdc.com> References: <1498555178-12106-1-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1498555178-12106-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Content-Language: en-US Content-ID: <47F8AE342567964F8275DB21191F81F4-+cFlbfsKLD6cE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org" Cc: "vijayi-R1PCaG5FPJG/3pe1ocb+swC/G2K4zDHf@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, 2017-06-27 at 12:19 +0300, Sagi Grimberg wrote: > From: Vijay Immanuel >=20 > If we modified the qp to ERROR state, and > drained the recieve queue, post_recv must ^^^^^^^ receive? > trigger the responder task to complete > the drain work request. >=20 > Cc: Bart Van Assche > Signed-off-by: Vijay Immanuel > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/sw/rxe/rxe_resp.c | 3 +++ > drivers/infiniband/sw/rxe/rxe_verbs.c | 3 +++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw= /rxe/rxe_resp.c > index 23039768f541..f66b48c114ac 100644 > --- a/drivers/infiniband/sw/rxe/rxe_resp.c > +++ b/drivers/infiniband/sw/rxe/rxe_resp.c > @@ -1217,6 +1217,9 @@ void rxe_drain_req_pkts(struct rxe_qp *qp, bool not= ify) > kfree_skb(skb); > } > =20 > + if (notify) > + return; > + > while (!qp->srq && qp->rq.queue && queue_head(qp->rq.queue)) > advance_consumer(qp->rq.queue); Since an "if (...) return" statement is added, please consider moving the qp->srq test out of the while-loop and into the if-expression. Anyway: Reviewed-by: Bart Van Assche = -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html