From: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
To: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org"
<Devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-core] bnxt_re: Fix -Wimplicit-fallthrough warnings in GCC 7.1
Date: Thu, 13 Jul 2017 15:06:11 +0000 [thread overview]
Message-ID: <1499958370.2740.4.camel@wdc.com> (raw)
In-Reply-To: <20170713133935.1206-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Thu, 2017-07-13 at 16:39 +0300, Leon Romanovsky wrote:
> diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c
> index 1fe79671..da0fe733 100644
> --- a/providers/bnxt_re/verbs.c
> +++ b/providers/bnxt_re/verbs.c
> @@ -1220,6 +1220,7 @@ int bnxt_re_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr,
> * LE platform be32toh will do the job.
> */
> hdr->key_immd = htole32(be32toh(wr->imm_data));
> + /* FALLTHROUGH */
Hello Leon,
In other rdma-core source files the annotation "/* fall through */" is used.
See also the output of git grep -nHi '/\* *fall[ -]*through'. Should we ensure
that these annotations are consistent in the rdma-core source tree?
Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-13 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 13:39 [PATCH rdma-core] bnxt_re: Fix -Wimplicit-fallthrough warnings in GCC 7.1 Leon Romanovsky
[not found] ` <20170713133935.1206-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-13 15:06 ` Bart Van Assche [this message]
[not found] ` <1499958370.2740.4.camel-Sjgp3cTcYWE@public.gmane.org>
2017-07-13 15:34 ` Leon Romanovsky
2017-07-13 17:51 ` Jason Gunthorpe
[not found] ` <20170713175122.GD11069-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-13 17:54 ` Bart Van Assche
[not found] ` <1499968451.2740.14.camel-Sjgp3cTcYWE@public.gmane.org>
2017-07-13 18:15 ` Jason Gunthorpe
[not found] ` <20170713181536.GA4771-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-13 19:08 ` Leon Romanovsky
[not found] ` <20170713190829.GQ1528-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-07-13 19:24 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499958370.2740.4.camel@wdc.com \
--to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
--cc=Devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox