Re: [PATCH rdma-rc 2/7] IB/IPoIB: Don't update neigh validity for unresolved entries

Doug Ledford
2016-06-06T23:59:59Z

[-- Attachment #1.1: Type: text/plain, Size: 647 bytes --]

On 6/5/2016 5:10 PM, Or Gerlitz wrote:

>> - neigh->alive = jiffies;
>> +
>> + if (likely(skb_queue_len(&neigh->queue) < IPOIB_MAX_PATH_REC_QUEUE))
>> + neigh->alive = jiffies;
>
> why testing the queue len makes things right?

I'm with Or on this one. This test doesn't make sense unless you assume
that the neighbor is being hit with a steady stream of packets. If
someone just runs ping -c 1 to a dead neighbor, this test will fail.
The idea of the patch is OK, but the test needs to be reworked for
situations other than a blasting stream of data.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]