From: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
To: "jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org"
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "bvanassche-HInyCGIudOg@public.gmane.org"
<bvanassche-HInyCGIudOg@public.gmane.org>
Subject: Re: [PATCH rdma-core 1/8] srp_daemon: Move the setup of the wakeup_pipe after openlog
Date: Wed, 26 Jul 2017 20:37:07 +0000 [thread overview]
Message-ID: <1501101426.2671.6.camel@wdc.com> (raw)
In-Reply-To: <1501099152-6344-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Wed, 2017-07-26 at 13:59 -0600, Jason Gunthorpe wrote:
> Pipe setup failure triggers logging calls which shouldn't happen until
> logging has been setup. Instead move this setup to after each of the
> two configuration steps.
>
> Bart says that wakeup_pipe[] is not used by ibsrpdm, so this also
> drops the pipe setup and signal change from that code path.
Reviewed-by: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-26 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 19:59 [PATCH rdma-core 0/8] Various fixes for daemons and systemd Jason Gunthorpe
[not found] ` <1501099152-6344-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-26 19:59 ` [PATCH rdma-core 1/8] srp_daemon: Move the setup of the wakeup_pipe after openlog Jason Gunthorpe
[not found] ` <1501099152-6344-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-26 20:37 ` Bart Van Assche [this message]
2017-07-26 19:59 ` [PATCH rdma-core 2/8] srp_daemon: Fix missing free_config for ibsrpdm Jason Gunthorpe
[not found] ` <1501099152-6344-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-26 20:37 ` Bart Van Assche
2017-07-26 19:59 ` [PATCH rdma-core 3/8] srp_daemon: Add a --systemd option Jason Gunthorpe
[not found] ` <1501099152-6344-4-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-26 20:37 ` Bart Van Assche
2017-07-27 14:12 ` Benjamin Drung
[not found] ` <1501164749.4572.30.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-07-27 16:48 ` Jason Gunthorpe
[not found] ` <20170727164851.GB13245-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-28 10:35 ` Benjamin Drung
[not found] ` <1501238107.4572.39.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-07-28 15:46 ` Bart Van Assche
2017-07-28 15:56 ` Jason Gunthorpe
2017-07-26 19:59 ` [PATCH rdma-core 4/8] Consistently open syslog in daemons Jason Gunthorpe
2017-07-26 19:59 ` [PATCH rdma-core 5/8] iwpmd: Move iwpmd.1 man page to iwpmd.8 Jason Gunthorpe
2017-07-26 19:59 ` [PATCH rdma-core 6/8] iwpm: Use daemon() instead of open coding a version Jason Gunthorpe
2017-07-26 19:59 ` [PATCH rdma-core 7/8] iwpmd: Add --systemd option Jason Gunthorpe
2017-07-26 19:59 ` [PATCH rdma-core 8/8] rdma-ndd: Tidy getopt_long call Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501101426.2671.6.camel@wdc.com \
--to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox