rdma-core rpm for SuSE

rdma-core rpm for SuSE

[Amrani, Ram]

Hi Jason,
I see folders with rpm creating scripts for Debian and Red Hat.
How is a SuSE rpm generated?

Thanks,
Ram


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Johannes Thumshirn]

On Thu, Aug 03, 2017 at 11:12:18AM +0000, Amrani, Ram wrote:
> Hi Jason,
> I see folders with rpm creating scripts for Debian and Red Hat.
> How is a SuSE rpm generated?

Hi Ram,

Please have a look at:
https://build.opensuse.org/package/show/science:HPC/rdma-core

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn-l3A5Bk7waGM@public.gmane.org                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Bart Van Assche]

On Thu, 2017-08-03 at 13:35 +0200, Johannes Thumshirn wrote:
> On Thu, Aug 03, 2017 at 11:12:18AM +0000, Amrani, Ram wrote:
> > Hi Jason,
> > I see folders with rpm creating scripts for Debian and Red Hat.
> > How is a SuSE rpm generated?
> 
> Please have a look at:
> https://build.opensuse.org/package/show/science:HPC/rdma-core

Hello Johannes,

Sorry but my opinion is that users should not have to rely on out-of-tree
patches to build an rdma-core RPM for SuSE systems. BTW, the script that I
use myself to build a SuSE rdma-core RPM is as follows:


#!/bin/bash

rpmtopdir=$PWD/rpmbuilddir
name=rdma-core
version=$(sed -n 's/^Version:[[:blank:]]*//p' rdma-core.spec) &&
    rm -rf "${rpmtopdir}" &&
    mkdir -p "${rpmtopdir}"/{BUILD,RPMS,SOURCES,SPECS,SRPMS} &&
    git archive --prefix "rdma-core-${version}/" --output "${rpmtopdir}/SOURCES/${name}-${version}.tgz" HEAD &&
    rpmbuild --define="%_topdir ${rpmtopdir}" -ba ${name}.spec


Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Nicolas Morey-Chaisemartin]

Le 03/08/2017 à 17:49, Bart Van Assche a écrit :
> On Thu, 2017-08-03 at 13:35 +0200, Johannes Thumshirn wrote:
>> On Thu, Aug 03, 2017 at 11:12:18AM +0000, Amrani, Ram wrote:
>>> Hi Jason,
>>> I see folders with rpm creating scripts for Debian and Red Hat.
>>> How is a SuSE rpm generated?
>> Please have a look at:
>> https://build.opensuse.org/package/show/science:HPC/rdma-core
> Hello Johannes,
>
> Sorry but my opinion is that users should not have to rely on out-of-tree
> patches to build an rdma-core RPM for SuSE systems. BTW, the script that I
> use myself to build a SuSE rdma-core RPM is as follows:
>
>
> #!/bin/bash
>
> rpmtopdir=$PWD/rpmbuilddir
> name=rdma-core
> version=$(sed -n 's/^Version:[[:blank:]]*//p' rdma-core.spec) &&
>     rm -rf "${rpmtopdir}" &&
>     mkdir -p "${rpmtopdir}"/{BUILD,RPMS,SOURCES,SPECS,SRPMS} &&
>     git archive --prefix "rdma-core-${version}/" --output "${rpmtopdir}/SOURCES/${name}-${version}.tgz" HEAD &&
>     rpmbuild --define="%_topdir ${rpmtopdir}" -ba ${name}.spec
>
>
> Bart.

Agreed.
We have a different spec file due to SUSE packaging policies, and some path differences but the default one works.
As this is new, I wanted to make sure it works well before submitting it.
With v15 coming out and the associated systemd/udev changes, I'll have to update the spec and validate it but once this is done I'll send a patch to this ML and get it upstreamed.

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Jason Gunthorpe]

On Thu, Aug 03, 2017 at 05:59:31PM +0200, Nicolas Morey-Chaisemartin wrote:

> We have a different spec file due to SUSE packaging policies, and
> some path differences but the default one works.  As this is new, I
> wanted to make sure it works well before submitting it.  With v15
> coming out and the associated systemd/udev changes, I'll have to
> update the spec and validate it but once this is done I'll send a
> patch to this ML and get it upstreamed.

I think that would be great..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Bart Van Assche]

On Thu, 2017-08-03 at 17:59 +0200, Nicolas Morey-Chaisemartin wrote:
> We have a different spec file due to SUSE packaging policies, and some
> path differences but the default one works. As this is new, I wanted to
> make sure it works well before submitting it. With v15 coming out and the
> associated systemd/udev changes, I'll have to update the spec and validate
> it but once this is done I'll send a patch to this ML and get it upstreamed.

Hello Nicolas,

Do you plan to submit an entirely new RPM or changes to the rdma-core.spec
file in the top-level directory? Personally I strongly prefer the latter. We
have already three groups of distro packaging files and that is really annoying
to rdma-core contributors because every packaging change has to be tested three
times (rdma-core.spec, redhat/rdma-core.spec and debian/*.install). Adding a
fourth packaging file would increase the maintenance burden even further.

Thanks,

Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Jason Gunthorpe]

On Thu, Aug 03, 2017 at 05:14:11PM +0000, Bart Van Assche wrote:
> On Thu, 2017-08-03 at 17:59 +0200, Nicolas Morey-Chaisemartin wrote:
> > We have a different spec file due to SUSE packaging policies, and some
> > path differences but the default one works. As this is new, I wanted to
> > make sure it works well before submitting it. With v15 coming out and the
> > associated systemd/udev changes, I'll have to update the spec and validate
> > it but once this is done I'll send a patch to this ML and get it upstreamed.
> 
> Hello Nicolas,
> 
> Do you plan to submit an entirely new RPM or changes to the rdma-core.spec
> file in the top-level directory? Personally I strongly prefer the latter. We
> have already three groups of distro packaging files and that is really annoying
> to rdma-core contributors because every packaging change has to be tested three
> times (rdma-core.spec, redhat/rdma-core.spec and debian/*.install). Adding a
> fourth packaging file would increase the maintenance burden even further.

If suse contributes their spec file I think we could delete the top
level rdma-core.spec

There are enough differences in the suse spec file I suspect it would
be more maintainable to have it separate.

We still have to test the builds against that configuration anyhow, I
dont see a big burden there - so long as cbuild can run an appropriate
suse build (opensuse is OK for testing?)..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: rdma-core rpm for SuSE

[Amrani, Ram]

> On Thu, 2017-08-03 at 13:35 +0200, Johannes Thumshirn wrote:
> > On Thu, Aug 03, 2017 at 11:12:18AM +0000, Amrani, Ram wrote:
> > > Hi Jason,
> > > I see folders with rpm creating scripts for Debian and Red Hat.
> > > How is a SuSE rpm generated?
> >
> > Please have a look at:
> > https://build.opensuse.org/package/show/science:HPC/rdma-core
> 
> Hello Johannes,
> 
> Sorry but my opinion is that users should not have to rely on out-of-tree
> patches to build an rdma-core RPM for SuSE systems. BTW, the script that I
> use myself to build a SuSE rdma-core RPM is as follows:
> 
> 
> #!/bin/bash
> 
> rpmtopdir=$PWD/rpmbuilddir
> name=rdma-core
> version=$(sed -n 's/^Version:[[:blank:]]*//p' rdma-core.spec) &&
>     rm -rf "${rpmtopdir}" &&
>     mkdir -p "${rpmtopdir}"/{BUILD,RPMS,SOURCES,SPECS,SRPMS} &&
>     git archive --prefix "rdma-core-${version}/" --output "${rpmtopdir}/SOURCES/${name}-${version}.tgz" HEAD &&
>     rpmbuild --define="%_topdir ${rpmtopdir}" -ba ${name}.spec
> 
> 
> Bart.

Thanks Johannes and Bart.
We'll try it out.

Ram

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rdma-core rpm for SuSE

[Nicolas Morey-Chaisemartin]

Le 03/08/2017 à 19:29, Jason Gunthorpe a écrit :
> On Thu, Aug 03, 2017 at 05:14:11PM +0000, Bart Van Assche wrote:
>> On Thu, 2017-08-03 at 17:59 +0200, Nicolas Morey-Chaisemartin wrote:
>>> We have a different spec file due to SUSE packaging policies, and some
>>> path differences but the default one works. As this is new, I wanted to
>>> make sure it works well before submitting it. With v15 coming out and the
>>> associated systemd/udev changes, I'll have to update the spec and validate
>>> it but once this is done I'll send a patch to this ML and get it upstreamed.
>> Hello Nicolas,
>>
>> Do you plan to submit an entirely new RPM or changes to the rdma-core.spec
>> file in the top-level directory? Personally I strongly prefer the latter. We
>> have already three groups of distro packaging files and that is really annoying
>> to rdma-core contributors because every packaging change has to be tested three
>> times (rdma-core.spec, redhat/rdma-core.spec and debian/*.install). Adding a
>> fourth packaging file would increase the maintenance burden even further.
> If suse contributes their spec file I think we could delete the top
> level rdma-core.spec
>
> There are enough differences in the suse spec file I suspect it would
> be more maintainable to have it separate.
>
> We still have to test the builds against that configuration anyhow, I
> dont see a big burden there - so long as cbuild can run an appropriate
> suse build (opensuse is OK for testing?)..
>
> Jason
Yes a separate spec makes more sense.
With the amount differences we have, it would be hellish to maintain a common spec file with redhat and most of the stuff would have to be done twice anyway.

And yes, the RPM works with both SLE (12SP3), OpenSUSE Leap (>=42.2) and TumbleWeed without any issue.

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html