From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [rdma-next v3 17/24] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct
Date: Thu, 24 Aug 2017 16:41:06 -0400 [thread overview]
Message-ID: <1503607266.78641.49.camel@redhat.com> (raw)
In-Reply-To: <20170817125055.31424-18-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Thu, 2017-08-17 at 15:50 +0300, Leon Romanovsky wrote:
> From: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> rss_key_len is not in use and need to be removed.
I fixed this commit message as I took this in.
> Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP")
> Signed-off-by: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> include/uapi/rdma/mlx4-abi.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4-
> abi.h
> index 0e10102861b5..c55f60e05f86 100644
> --- a/include/uapi/rdma/mlx4-abi.h
> +++ b/include/uapi/rdma/mlx4-abi.h
> @@ -98,8 +98,7 @@ struct mlx4_ib_create_srq_resp {
> struct mlx4_ib_create_qp_rss {
> __u64 rx_hash_fields_mask;
> __u8 rx_hash_function;
> - __u8 rx_key_len;
> - __u8 reserved[6];
> + __u8 reserved[7];
> __u8 rx_hash_key[40];
> __u32 comp_mask;
> __u32 reserved1;
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-24 20:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 12:50 [pull request][rdma-next v3 00/24] RDMA core, drivers and IPoIB fixes Leon Romanovsky
[not found] ` <20170817125055.31424-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-17 12:50 ` [rdma-next v3 01/24] IB/cma: Fix erroneous validation of supported default GID type Leon Romanovsky
[not found] ` <20170817125055.31424-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-23 8:50 ` Selvin Xavier
2017-08-17 12:50 ` [rdma-next v3 02/24] IB/uverbs: Introduce and use helper functions to copy ah attributes Leon Romanovsky
[not found] ` <20170817125055.31424-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:40 ` Doug Ledford
[not found] ` <1503607242.78641.48.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-27 11:10 ` Leon Romanovsky
[not found] ` <20170827111059.GQ1724-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28 15:15 ` Doug Ledford
[not found] ` <1503933314.78641.82.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-28 15:55 ` Leon Romanovsky
[not found] ` <20170828155552.GB23726-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28 16:32 ` Doug Ledford
[not found] ` <1503937924.78641.94.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-28 17:20 ` Leon Romanovsky
[not found] ` <20170828172026.GE23726-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28 17:24 ` Leon Romanovsky
2017-08-28 18:09 ` Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 03/24] RDMA/mlx4: Don't use uninitialized variable Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 04/24] RDMA/mlx4: Fix create qp command alignment Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 05/24] RDMA/(core,ulp): Convert register/unregister event handler to be void Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 06/24] RDMA/core: Cleanup device capability enum Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 07/24] RDMA/core: Delete BUG() from unreachable flow Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 08/24] RDMA/core: Refactor get link layer wrapper Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 09/24] RDMA/mlx4: Remove gfp_mask argument from acquire_group call Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 10/24] RDMA/usnic: Fix remove address space warning Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 11/24] RDMA/mthca: Make explicit conversion to 64bit value Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 12/24] IB/mlx4: Fix some spelling mistakes Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 13/24] IB/mlx5: " Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 14/24] IB/mlx5: Add necessary delay drop assignment Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 15/24] IB/mlx4: Fix RSS QP type in creation verb Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 16/24] IB/mlx4: Fix struct mlx4_ib_create_wq alignment Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 17/24] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Leon Romanovsky
[not found] ` <20170817125055.31424-18-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:41 ` Doug Ledford [this message]
2017-08-17 12:50 ` [rdma-next v3 18/24] IB/mlx4: Check that reserved fields in mlx4_ib_create_qp_rss are zero Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 19/24] IB/ipoib: Sync between remove_one to sysfs calls that use rtnl_lock Leon Romanovsky
[not found] ` <20170817125055.31424-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:49 ` Doug Ledford
2017-08-17 12:50 ` [rdma-next v3 20/24] IB/ipoib: Add get statistics support to SRIOV VF Leon Romanovsky
[not found] ` <20170817125055.31424-21-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:44 ` Doug Ledford
[not found] ` <1503607480.78641.51.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-27 11:17 ` Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 21/24] IB/rxe: Make rxe_counter_name static Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 22/24] RDMA/mlx5: Limit scope of get vector affinity local function Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 23/24] RDMA/mlx4: Properly annotate link layer variable Leon Romanovsky
2017-08-17 12:50 ` [rdma-next v3 24/24] RDMA/nes: Remove zeroed parameter from port query callback Leon Romanovsky
2017-08-24 20:52 ` [pull request][rdma-next v3 00/24] RDMA core, drivers and IPoIB fixes Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503607266.78641.49.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).