* [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue()
@ 2017-08-25 8:18 Dan Carpenter
2017-08-29 0:36 ` Doug Ledford
2017-08-29 7:02 ` Kalderon, Michal
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-08-25 8:18 UTC (permalink / raw)
To: Ram Amrani, Kalderon, Michal
Cc: Ariel Elior, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
We should return -ENOMEM if the kzalloc() fails. We currently return
success.
Fixes: 69ad0e7fe845 ("RDMA/qedr: Add support for iWARP in user space")
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index 4e14a558734b..bce4f79370e6 100644
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -821,8 +821,10 @@ static inline int qedr_init_user_queue(struct ib_ucontext *ib_ctx,
FW_PAGE_SHIFT);
} else {
q->pbl_tbl = kzalloc(sizeof(*q->pbl_tbl), GFP_KERNEL);
- if (!q->pbl_tbl)
+ if (!q->pbl_tbl) {
+ rc = -ENOMEM;
goto err0;
+ }
}
return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue()
2017-08-25 8:18 [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue() Dan Carpenter
@ 2017-08-29 0:36 ` Doug Ledford
2017-08-29 7:02 ` Kalderon, Michal
1 sibling, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2017-08-29 0:36 UTC (permalink / raw)
To: Dan Carpenter, Ram Amrani, Michal
Cc: Ariel Elior, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Fri, 2017-08-25 at 11:18 +0300, Dan Carpenter wrote:
> We should return -ENOMEM if the kzalloc() fails. We currently return
> success.
>
> Fixes: 69ad0e7fe845 ("RDMA/qedr: Add support for iWARP in user
> space")
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Thanks, applied on top of my k.o/net-next-based branch.
>
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index 4e14a558734b..bce4f79370e6 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -821,8 +821,10 @@ static inline int qedr_init_user_queue(struct
> ib_ucontext *ib_ctx,
> FW_PAGE_SHIFT);
> } else {
> q->pbl_tbl = kzalloc(sizeof(*q->pbl_tbl),
> GFP_KERNEL);
> - if (!q->pbl_tbl)
> + if (!q->pbl_tbl) {
> + rc = -ENOMEM;
> goto err0;
> + }
> }
>
> return 0;
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue()
2017-08-25 8:18 [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue() Dan Carpenter
2017-08-29 0:36 ` Doug Ledford
@ 2017-08-29 7:02 ` Kalderon, Michal
1 sibling, 0 replies; 3+ messages in thread
From: Kalderon, Michal @ 2017-08-29 7:02 UTC (permalink / raw)
To: Dan Carpenter, Amrani, Ram, Kalderon@mwanda
Cc: Elior, Ariel, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
From: Dan Carpenter [mailto:dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org]
Sent: Friday, August 25, 2017 11:19 AM
> To: Amrani, Ram <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>; Kalderon@mwanda;
> Kalderon, Michal <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Cc: Elior, Ariel <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>; Doug Ledford
> <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>; Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>; Hal
> Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue()
>
> We should return -ENOMEM if the kzalloc() fails. We currently return
> success.
>
> Fixes: 69ad0e7fe845 ("RDMA/qedr: Add support for iWARP in user space")
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index 4e14a558734b..bce4f79370e6 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -821,8 +821,10 @@ static inline int qedr_init_user_queue(struct
> ib_ucontext *ib_ctx,
> FW_PAGE_SHIFT);
> } else {
> q->pbl_tbl = kzalloc(sizeof(*q->pbl_tbl), GFP_KERNEL);
> - if (!q->pbl_tbl)
> + if (!q->pbl_tbl) {
> + rc = -ENOMEM;
> goto err0;
> + }
> }
>
> return 0;
Thanks, Dan
Acked-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-29 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-25 8:18 [PATCH] RDMA/qedr: Missing error code in qedr_init_user_queue() Dan Carpenter
2017-08-29 0:36 ` Doug Ledford
2017-08-29 7:02 ` Kalderon, Michal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox